You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2016/07/15 04:33:20 UTC

[jira] [Commented] (HIVE-12244) Refactoring code for avoiding of comparison of Strings and do comparison on Path

    [ https://issues.apache.org/jira/browse/HIVE-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378838#comment-15378838 ] 

Hive QA commented on HIVE-12244:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12817904/HIVE-12244.10.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/519/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/519/console
Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-519/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****

main:
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ spark-client ---
[INFO] Compiling 28 source files to /data/hive-ptest/working/apache-github-source-source/spark-client/target/classes
[WARNING] /data/hive-ptest/working/apache-github-source-source/spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java: /data/hive-ptest/working/apache-github-source-source/spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java uses or overrides a deprecated API.
[WARNING] /data/hive-ptest/working/apache-github-source-source/spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java: Recompile with -Xlint:deprecation for details.
[WARNING] /data/hive-ptest/working/apache-github-source-source/spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java: Some input files use unchecked or unsafe operations.
[WARNING] /data/hive-ptest/working/apache-github-source-source/spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcDispatcher.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ spark-client ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ spark-client ---
[INFO] Executing tasks

main:
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/spark-client/target/tmp
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/spark-client/target/warehouse
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/spark-client/target/tmp/conf
     [copy] Copying 15 files to /data/hive-ptest/working/apache-github-source-source/spark-client/target/tmp/conf
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ spark-client ---
[INFO] Compiling 5 source files to /data/hive-ptest/working/apache-github-source-source/spark-client/target/test-classes
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:copy (copy-guava-14) @ spark-client ---
[INFO] Configured Artifact: com.google.guava:guava:14.0.1:jar
[INFO] Copying guava-14.0.1.jar to /data/hive-ptest/working/apache-github-source-source/spark-client/target/dependency/guava-14.0.1.jar
[INFO] 
[INFO] --- maven-surefire-plugin:2.16:test (default-test) @ spark-client ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ spark-client ---
[INFO] Building jar: /data/hive-ptest/working/apache-github-source-source/spark-client/target/spark-client-2.2.0-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ spark-client ---
[INFO] 
[INFO] --- maven-install-plugin:2.4:install (default-install) @ spark-client ---
[INFO] Installing /data/hive-ptest/working/apache-github-source-source/spark-client/target/spark-client-2.2.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/spark-client/2.2.0-SNAPSHOT/spark-client-2.2.0-SNAPSHOT.jar
[INFO] Installing /data/hive-ptest/working/apache-github-source-source/spark-client/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/spark-client/2.2.0-SNAPSHOT/spark-client-2.2.0-SNAPSHOT.pom
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Hive Query Language 2.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-exec ---
[INFO] Deleting /data/hive-ptest/working/apache-github-source-source/ql/target
[INFO] Deleting /data/hive-ptest/working/apache-github-source-source/ql (includes = [datanucleus.log, derby.log], excludes = [])
[INFO] 
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @ hive-exec ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (generate-sources) @ hive-exec ---
[INFO] Executing tasks

main:
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/generated-sources/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/generated-sources/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/generated-test-sources/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen
Generating vector expression code
Generating vector expression test code
[INFO] Executed tasks
[INFO] 
[INFO] --- build-helper-maven-plugin:1.8:add-source (add-source) @ hive-exec ---
[INFO] Source directory: /data/hive-ptest/working/apache-github-source-source/ql/src/gen/thrift/gen-javabean added.
[INFO] Source directory: /data/hive-ptest/working/apache-github-source-source/ql/target/generated-sources/java added.
[INFO] 
[INFO] --- antlr3-maven-plugin:3.4:antlr (default) @ hive-exec ---
[INFO] ANTLR: Processing source directory /data/hive-ptest/working/apache-github-source-source/ql/src/java
ANTLR Parser Generator  Version 3.4
org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ hive-exec ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ hive-exec ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-exec ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-exec ---
[INFO] Compiling 2649 source files to /data/hive-ptest/working/apache-github-source-source/ql/target/classes
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java: Some input files use or override a deprecated API.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java: Recompile with -Xlint:deprecation for details.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/exec/RowSchema.java: Some input files use unchecked or unsafe operations.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/exec/RowSchema.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- build-helper-maven-plugin:1.8:add-test-source (add-test-sources) @ hive-exec ---
[INFO] Test Source directory: /data/hive-ptest/working/apache-github-source-source/ql/target/generated-test-sources/java added.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ hive-exec ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-exec ---
[INFO] Executing tasks

main:
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/tmp
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/warehouse
    [mkdir] Created dir: /data/hive-ptest/working/apache-github-source-source/ql/target/tmp/conf
     [copy] Copying 15 files to /data/hive-ptest/working/apache-github-source-source/ql/target/tmp/conf
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-exec ---
[INFO] Compiling 293 source files to /data/hive-ptest/working/apache-github-source-source/ql/target/test-classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING : 
[INFO] -------------------------------------------------------------
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java: Some input files use or override a deprecated API.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java: Recompile with -Xlint:deprecation for details.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/io/TestCombineHiveInputFormat.java: Some input files use unchecked or unsafe operations.
[WARNING] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/io/TestCombineHiveInputFormat.java: Recompile with -Xlint:unchecked for details.
[WARNING] Some messages have been simplified; recompile with -Xdiags:verbose to get full output
[INFO] 5 warnings 
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[307,31] incompatible types: java.util.LinkedHashMap<java.lang.String,java.util.ArrayList<java.lang.String>> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,java.util.ArrayList<java.lang.String>>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[311,37] incompatible types: java.util.LinkedHashMap<java.lang.String,org.apache.hadoop.hive.ql.plan.PartitionDesc> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,org.apache.hadoop.hive.ql.plan.PartitionDesc>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[314,31] incompatible types: java.util.LinkedHashMap<java.lang.String,java.util.ArrayList<java.lang.String>> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,java.util.ArrayList<java.lang.String>>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[318,37] incompatible types: java.util.LinkedHashMap<java.lang.String,org.apache.hadoop.hive.ql.plan.PartitionDesc> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,org.apache.hadoop.hive.ql.plan.PartitionDesc>
[INFO] 4 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Hive .............................................. SUCCESS [1.595s]
[INFO] Hive Shims Common ................................. SUCCESS [3.424s]
[INFO] Hive Shims 0.23 ................................... SUCCESS [2.291s]
[INFO] Hive Shims Scheduler .............................. SUCCESS [0.737s]
[INFO] Hive Shims ........................................ SUCCESS [0.553s]
[INFO] Hive Storage API .................................. SUCCESS [1.339s]
[INFO] Hive ORC .......................................... SUCCESS [5.149s]
[INFO] Hive Common ....................................... SUCCESS [4.422s]
[INFO] Hive Service RPC .................................. SUCCESS [3.688s]
[INFO] Hive Serde ........................................ SUCCESS [4.141s]
[INFO] Hive Metastore .................................... SUCCESS [20.122s]
[INFO] Hive Ant Utilities ................................ SUCCESS [0.410s]
[INFO] Hive Llap Common .................................. SUCCESS [3.331s]
[INFO] Hive Llap Client .................................. SUCCESS [1.289s]
[INFO] Hive Llap Tez ..................................... SUCCESS [1.781s]
[INFO] Spark Remote Client ............................... SUCCESS [2.619s]
[INFO] Hive Query Language ............................... FAILURE [39.104s]
[INFO] Hive Llap Server .................................. SKIPPED
[INFO] Hive Service ...................................... SKIPPED
[INFO] Hive Accumulo Handler ............................. SKIPPED
[INFO] Hive JDBC ......................................... SKIPPED
[INFO] Hive Beeline ...................................... SKIPPED
[INFO] Hive CLI .......................................... SKIPPED
[INFO] Hive Contrib ...................................... SKIPPED
[INFO] Hive HBase Handler ................................ SKIPPED
[INFO] Hive HCatalog ..................................... SKIPPED
[INFO] Hive HCatalog Core ................................ SKIPPED
[INFO] Hive HCatalog Pig Adapter ......................... SKIPPED
[INFO] Hive HCatalog Server Extensions ................... SKIPPED
[INFO] Hive HCatalog Webhcat Java Client ................. SKIPPED
[INFO] Hive HCatalog Webhcat ............................. SKIPPED
[INFO] Hive HCatalog Streaming ........................... SKIPPED
[INFO] Hive HPL/SQL ...................................... SKIPPED
[INFO] Hive HWI .......................................... SKIPPED
[INFO] Hive Llap External Client ......................... SKIPPED
[INFO] Hive Shims Aggregator ............................. SKIPPED
[INFO] Hive TestUtils .................................... SKIPPED
[INFO] Hive Packaging .................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:36.626s
[INFO] Finished at: Fri Jul 15 04:33:20 UTC 2016
[INFO] Final Memory: 142M/1191M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hive-exec: Compilation failure: Compilation failure:
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[307,31] incompatible types: java.util.LinkedHashMap<java.lang.String,java.util.ArrayList<java.lang.String>> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,java.util.ArrayList<java.lang.String>>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[311,37] incompatible types: java.util.LinkedHashMap<java.lang.String,org.apache.hadoop.hive.ql.plan.PartitionDesc> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,org.apache.hadoop.hive.ql.plan.PartitionDesc>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[314,31] incompatible types: java.util.LinkedHashMap<java.lang.String,java.util.ArrayList<java.lang.String>> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,java.util.ArrayList<java.lang.String>>
[ERROR] /data/hive-ptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:[318,37] incompatible types: java.util.LinkedHashMap<java.lang.String,org.apache.hadoop.hive.ql.plan.PartitionDesc> cannot be converted to java.util.LinkedHashMap<org.apache.hadoop.fs.Path,org.apache.hadoop.hive.ql.plan.PartitionDesc>
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hive-exec
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12817904 - PreCommit-HIVE-MASTER-Build

> Refactoring code for avoiding of comparison of Strings and do comparison on Path
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-12244
>                 URL: https://issues.apache.org/jira/browse/HIVE-12244
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 0.13.0, 0.14.0, 1.0.0, 1.2.1
>            Reporter: Alina Abramova
>            Assignee: Zoltan Haindrich
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.2.1
>
>         Attachments: HIVE-12244.1.patch, HIVE-12244.10.patch, HIVE-12244.2.patch, HIVE-12244.3.patch, HIVE-12244.4.patch, HIVE-12244.5.patch, HIVE-12244.6.patch, HIVE-12244.7.patch, HIVE-12244.8.patch, HIVE-12244.8.patch, HIVE-12244.9.patch
>
>
> In Hive often String is used for representation path and it causes new issues.
> We need to compare it with equals() but comparing Strings often is not right in terms comparing paths .
> I think if we use Path from org.apache.hadoop.fs we will avoid new problems in future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)