You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/02 21:43:46 UTC
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
Where's the `Makefile` change?
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 43)
<https://reviews.apache.org/r/39019/#comment163028>
Presumably, this will always be true for Stout. So do we need the `#ifdef`?
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 50 - 52)
<https://reviews.apache.org/r/39019/#comment163025>
Maybe add a `// Forward declarations.` comment here.
- Joseph Wu
On Oct. 29, 2015, 10:59 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 10:59 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 43
> > <https://reviews.apache.org/r/39019/diff/5/?file=1112922#file1112922line43>
> >
> > Presumably, this will always be true for Stout. So do we need the `#ifdef`?
Yes, that's fair. This issue should be resolved.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:13 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 43
> > <https://reviews.apache.org/r/39019/diff/5/?file=1112922#file1112922line43>
> >
> > Presumably, this will always be true for Stout. So do we need the `#ifdef`?
>
> Alex Clemmer wrote:
> Yes, that's fair. This issue should be resolved.
Note that the spaces are now pulled out from around the `extern` tags because the linter asks for it.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>