You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 16:03:08 UTC
[GitHub] [arrow-datafusion] alamb commented on pull request #3955: Change back to non async interface for try_into_logical_plan
alamb commented on PR #3955:
URL: https://github.com/apache/arrow-datafusion/pull/3955#issuecomment-1290801916
> Thanks @avantgardnerio for the explanation. In case of network usage or other IO usage, we can refer to the object store interface implementation with spawn blocking.
Yeah, the `async` is very infectious -- so adding async definitely causes non trivial downstream churn.
@yahoNanJing would an alternative approach be to create a PR in Ballista to update the code in question to be async?
@avantgardnerio perhaps @yahoNanJing is suggesting something like https://docs.rs/tokio/1.21.2/tokio/runtime/struct.Runtime.html#method.block_on which blocks a thread and waits for an async method to resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org