[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830256617



##########
File path: superset-frontend/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
##########
@@ -17,31 +17,38 @@
  * under the License.
  */
 
-import React, { CSSProperties, useMemo } from 'react';
+import React, { CSSProperties } from 'react';
+import { css, styled } from '../../style';
 import { t } from '../../translation';
 
 const MESSAGE_STYLES: CSSProperties = { maxWidth: 800 };
-const TITLE_STYLES: CSSProperties = {
-  fontSize: 16,
-  fontWeight: 'bold',
-  paddingBottom: 8,
-};
-const BODY_STYLES: CSSProperties = { fontSize: 14 };
 const MIN_WIDTH_FOR_BODY = 250;
 
-const generateContainerStyles: (
-  height: number | string,
-  width: number | string,
-) => CSSProperties = (height: number | string, width: number | string) => ({
-  alignItems: 'center',
-  display: 'flex',
-  flexDirection: 'column',
-  height,
-  justifyContent: 'center',
-  padding: 16,
-  textAlign: 'center',
-  width,
-});
+const Container = styled.div<{
+  width: number | string;
+  height: number | string;
+}>`
+  ${({ theme, width, height }) => css`
+    align-items: center;
+    display: flex;
+    flex-direction: column;
+    justify-content: center;
+    text-align: center;
+    height: ${height}px;
+    width: ${width}px;
+    //padding: ${theme.gridUnit * 4}px;

Review comment:
       Should we uncomment or delete it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org