You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/17 08:41:21 UTC

[GitHub] [flink] XComp opened a new pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

XComp opened a new pull request #19129:
URL: https://github.com/apache/flink/pull/19129


   ## What is the purpose of the change
   
   The issue before the fix was, that using getPath would strip
   off the scheme information which causes problems in situations
   where the FileSystem is not the default FileSystem.
   
   ## Brief change log
   
   * removes `getPath` from path construction methods
   
   ## Verifying this change
   
   * Added unit tests for verifying that the constructed paths' parent matches the basePath
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19129:
URL: https://github.com/apache/flink/pull/19129#issuecomment-1070548884


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5412449c90122a600e0b42d87d5666b01e2533d2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231",
       "triggerID" : "1bbd3a439b1ec94ec0f936cd330222647fe1fca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5412449c90122a600e0b42d87d5666b01e2533d2 UNKNOWN
   * 1bbd3a439b1ec94ec0f936cd330222647fe1fca4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33231) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
XComp merged pull request #19129:
URL: https://github.com/apache/flink/pull/19129


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #19129: [FLINK-26698][runtime] Uses the actual basePath instance instead of only the path of Path instance

Posted by GitBox <gi...@apache.org>.
XComp merged pull request #19129:
URL: https://github.com/apache/flink/pull/19129


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org