You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/21 18:29:45 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
xinrong-databricks opened a new pull request #34061:
URL: https://github.com/apache/spark/pull/34061
### What changes were proposed in this pull request?
Fix filtering a Series (without a name) by a boolean Series.
### Why are the changes needed?
Bug fix.
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924497217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924520262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48001/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925203465
**[Test build #143510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143510/testReport)** for PR 34061 at commit [`70b3cdc`](https://github.com/apache/spark/commit/70b3cdccd9284c155f81768ae5a08d5033924e0f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924468970
**[Test build #143489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143489/testReport)** for PR 34061 at commit [`e4ebcee`](https://github.com/apache/spark/commit/e4ebceef47e0a8ca3b574eb8cfaee8b021ec65fd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924475312
**[Test build #143490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143490/testReport)** for PR 34061 at commit [`d91bd01`](https://github.com/apache/spark/commit/d91bd01f958acebf93b8c42b2571ff5b8a021016).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924495308
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48000/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r713498668
##########
File path: python/pyspark/pandas/tests/test_ops_on_diff_frames.py
##########
@@ -503,6 +503,12 @@ def test_loc_getitem_boolean_series(self):
(pdf1.A + 1).loc[pdf2.A > -3].sort_index(), (psdf1.A + 1).loc[psdf2.A > -3].sort_index()
)
+ pser = pd.Series([0, 1, 2, 3, 4], index=[20, 10, 30, 0, 50])
+ psser = ps.from_pandas(pser)
+ self.assert_eq(pser.loc[pdf2.A > -3].sort_index(), psser.loc[psdf2.A > -3].sort_index())
+ pser.name = psser.name = "B"
+ self.assert_eq(pser.loc[pdf2.A > -3].sort_index(), psser.loc[psdf2.A > -3].sort_index())
Review comment:
Could you also try with Series on the same anchor?
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
Review comment:
How about explicitly specify the column name instead of implicit name?
```py
name = ???
psdf = self._psdf_or_psser.to_frame(name)
```
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
+ return cast(Series, psdf[name][psdf[temp_col]]).rename(self._psdf_or_psser.name)
Review comment:
This is not what the original one is expecting.
```py
return type(self)(psdf[name])[psdf[temp_col]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924418840
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143486/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925174936
**[Test build #143510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143510/testReport)** for PR 34061 at commit [`70b3cdc`](https://github.com/apache/spark/commit/70b3cdccd9284c155f81768ae5a08d5033924e0f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925174936
**[Test build #143510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143510/testReport)** for PR 34061 at commit [`70b3cdc`](https://github.com/apache/spark/commit/70b3cdccd9284c155f81768ae5a08d5033924e0f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924418840
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143486/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r713498444
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
+ return cast(Series, psdf[name][psdf[temp_col]]).rename(self._psdf_or_psser.name)
Review comment:
This is not what the original one is expecting.
Should be:
```py
return type(self)(psdf[name])[psdf[temp_col]].rename(self._psdf_or_psser.name)
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924367662
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924515514
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48001/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924397483
**[Test build #143486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143486/testReport)** for PR 34061 at commit [`36672c5`](https://github.com/apache/spark/commit/36672c59048b82a69194ab25769ea2331e2aca49).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r714200185
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
Review comment:
Good idea, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r714201022
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
+ return cast(Series, psdf[name][psdf[temp_col]]).rename(self._psdf_or_psser.name)
Review comment:
Got it, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924397483
**[Test build #143486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143486/testReport)** for PR 34061 at commit [`36672c5`](https://github.com/apache/spark/commit/36672c59048b82a69194ab25769ea2331e2aca49).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924475312
**[Test build #143490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143490/testReport)** for PR 34061 at commit [`d91bd01`](https://github.com/apache/spark/commit/d91bd01f958acebf93b8c42b2571ff5b8a021016).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924449371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47997/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925292590
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924487766
**[Test build #143490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143490/testReport)** for PR 34061 at commit [`d91bd01`](https://github.com/apache/spark/commit/d91bd01f958acebf93b8c42b2571ff5b8a021016).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925292590
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924520262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48001/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924448402
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47997/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924297308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143482/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925292552
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924493698
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48001/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924458915
**[Test build #143489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143489/testReport)** for PR 34061 at commit [`e4ebcee`](https://github.com/apache/spark/commit/e4ebceef47e0a8ca3b574eb8cfaee8b021ec65fd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924473087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143489/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924426606
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47997/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924297308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143482/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925279584
Thanks! merging to master/3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin closed pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
ueshin closed pull request #34061:
URL: https://github.com/apache/spark/pull/34061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924251865
**[Test build #143482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143482/testReport)** for PR 34061 at commit [`da176bc`](https://github.com/apache/spark/commit/da176bc03cff54b70526f2148e13ee20e5995e98).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924414512
**[Test build #143486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143486/testReport)** for PR 34061 at commit [`36672c5`](https://github.com/apache/spark/commit/36672c59048b82a69194ab25769ea2331e2aca49).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924379881
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924251865
**[Test build #143482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143482/testReport)** for PR 34061 at commit [`da176bc`](https://github.com/apache/spark/commit/da176bc03cff54b70526f2148e13ee20e5995e98).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924473087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143489/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924458915
**[Test build #143489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143489/testReport)** for PR 34061 at commit [`e4ebcee`](https://github.com/apache/spark/commit/e4ebceef47e0a8ca3b574eb8cfaee8b021ec65fd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924336317
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925222153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r714200185
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
Review comment:
Good idea, then we don't rely on how `to_frame` processes input without a name. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924379881
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924478420
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48000/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925222153
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r713498444
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -439,7 +440,8 @@ def __getitem__(self, key: Any) -> Union["Series", "DataFrame"]:
temp_col = verify_temp_column_name(psdf, "__temp_col__")
psdf[temp_col] = key
- return type(self)(psdf[self._psdf_or_psser.name])[psdf[temp_col]]
+ name = self._psdf_or_psser.name or DEFAULT_SERIES_NAME
+ return cast(Series, psdf[name][psdf[temp_col]]).rename(self._psdf_or_psser.name)
Review comment:
This is not what the original one is expecting.
Should be:
```py
return type(self)(psdf[name].rename(self._psdf_or_psser.name))[psdf[temp_col]]
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924296572
**[Test build #143482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143482/testReport)** for PR 34061 at commit [`da176bc`](https://github.com/apache/spark/commit/da176bc03cff54b70526f2148e13ee20e5995e98).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924449371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47997/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34061:
URL: https://github.com/apache/spark/pull/34061#discussion_r714200045
##########
File path: python/pyspark/pandas/tests/test_ops_on_diff_frames.py
##########
@@ -503,6 +503,12 @@ def test_loc_getitem_boolean_series(self):
(pdf1.A + 1).loc[pdf2.A > -3].sort_index(), (psdf1.A + 1).loc[psdf2.A > -3].sort_index()
)
+ pser = pd.Series([0, 1, 2, 3, 4], index=[20, 10, 30, 0, 50])
+ psser = ps.from_pandas(pser)
+ self.assert_eq(pser.loc[pdf2.A > -3].sort_index(), psser.loc[psdf2.A > -3].sort_index())
+ pser.name = psser.name = "B"
+ self.assert_eq(pser.loc[pdf2.A > -3].sort_index(), psser.loc[psdf2.A > -3].sort_index())
Review comment:
Certainly, added `IndexingTest.test_loc_getitem_boolean_series`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-925232662
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34061: [SPARK-36818][PYTHON] Fix filtering a Series by a boolean Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34061:
URL: https://github.com/apache/spark/pull/34061#issuecomment-924497217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org