You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2017/06/02 13:38:05 UTC
spark git commit: [SPARK-20942][WEB-UI] The title style about field
is error in the history server web ui.
Repository: spark
Updated Branches:
refs/heads/master 0e31e28d4 -> 625cebfde
[SPARK-20942][WEB-UI] The title style about field is error in the history server web ui.
## What changes were proposed in this pull request?
1.The title style about field is error.
fix before:
fix after:
executor-page style:
2.Title text description, 'the application' should be changed to 'this application'.
3.Analysis of code:
$('#history-summary [data-toggle="tooltip"]').tooltip();
The id of 'history-summary' is not there. We only contain id of 'history-summary-table'.
## How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: guoxiaolong <gu...@zte.com.cn>
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Author: guoxiaolongzte <gu...@zte.com.cn>
Closes #18170 from guoxiaolongzte/SPARK-20942.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/625cebfd
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/625cebfd
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/625cebfd
Branch: refs/heads/master
Commit: 625cebfde632361122e0db3452c4cc38147f696f
Parents: 0e31e28
Author: guoxiaolong <gu...@zte.com.cn>
Authored: Fri Jun 2 14:38:00 2017 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Fri Jun 2 14:38:00 2017 +0100
----------------------------------------------------------------------
.../spark/ui/static/historypage-template.html | 18 +++++++++---------
.../org/apache/spark/ui/static/historypage.js | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/625cebfd/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html b/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
index c2afa99..bfe31aa 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
+++ b/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
@@ -20,47 +20,47 @@
<thead>
<tr>
<th>
- <span data-toggle="tooltip" data-placement="right" title="ID of the application.">
+ <span data-toggle="tooltip" data-placement="top" title="ID of this application.">
App ID
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="above" title="Name of the application.">
+ <span data-toggle="tooltip" data-placement="top" title="Name of this application.">
App Name
</span>
</th>
<th class="attemptIDSpan">
- <span data-toggle="tooltip" data-placement="above" title="The attempt ID of this application since one application might be launched several times">
+ <span data-toggle="tooltip" data-placement="top" title="The attempt ID of this application since one application might be launched several times">
Attempt ID
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="right" title="Started time of this application.">
+ <span data-toggle="tooltip" data-placement="top" title="Started time of this application.">
Started
</span>
</th>
<th class="completedColumn">
- <span data-toggle="tooltip" data-placement="above" title="The completed time of this application.">
+ <span data-toggle="tooltip" data-placement="top" title="The completed time of this application.">
Completed
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="above" title="The duration time of this application.">
+ <span data-toggle="tooltip" data-placement="top" title="The duration time of this application.">
Duration
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="right" title="The Spark user of this application">
+ <span data-toggle="tooltip" data-placement="top" title="The Spark user of this application">
Spark User
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="above" title="The timestamp of the last updating on this application">
+ <span data-toggle="tooltip" data-placement="top" title="The timestamp of the last updating on this application">
Last Updated
</span>
</th>
<th>
- <span data-toggle="tooltip" data-placement="above" title="Download the event log for this application">
+ <span data-toggle="tooltip" data-placement="top" title="Download the event log for this application">
Event Log
</span>
</th>
http://git-wip-us.apache.org/repos/asf/spark/blob/625cebfd/core/src/main/resources/org/apache/spark/ui/static/historypage.js
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/historypage.js b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
index 7db8c27..5ec1ce1 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/historypage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/historypage.js
@@ -195,7 +195,7 @@ $(document).ready(function() {
}
$(selector).DataTable(conf);
- $('#hisotry-summary [data-toggle="tooltip"]').tooltip();
+ $('#history-summary [data-toggle="tooltip"]').tooltip();
});
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org