You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/01/04 18:22:27 UTC

[GitHub] [trafficserver] shinrich opened a new pull request #7408: Reactivate accecpt_no_activity_timeout

shinrich opened a new pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408


   Discussion in the issue.  Should also extend one of the autest timeout cases to exercise the accept_no_timeout for at least HTTP/1.x.
   
   This closes #7390.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on a change in pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#discussion_r571820430



##########
File path: proxy/ProtocolProbeSessionAccept.cc
##########
@@ -169,14 +169,20 @@ struct ProtocolProbeTrampoline : public Continuation, public ProtocolProbeSessio
 int
 ProtocolProbeSessionAccept::mainEvent(int event, void *data)
 {
+  static int no_activity_timeout = 0;
   if (event == NET_EVENT_ACCEPT) {
     ink_assert(data);
 
     VIO *vio;
     NetVConnection *netvc          = static_cast<NetVConnection *>(data);
     ProtocolProbeTrampoline *probe = new ProtocolProbeTrampoline(this, netvc->mutex, nullptr, nullptr);
 
-    // XXX we need to apply accept inactivity timeout here ...
+    // The connection has completed, set the accept inactivity timeout here to watch over the difference between the
+    // connection set up and the first transaction..
+    if (no_activity_timeout == 0) {

Review comment:
       Our doc says this config is "Reloadable", but this code doesn't look reloadable for me. 
   We need to change either doc or code.
   https://docs.trafficserver.apache.org/en/9.0.x/admin-guide/files/records.config.en.html#proxy-config-http-accept-no-activity-timeout




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-801307570


   Cherry-picked to v9.1.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-773654570






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-773654570


   @masaori335 is going to take a look at it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-792375910


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 removed a comment on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-792375846


   [approve ci]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 removed a comment on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-792375910


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich merged pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-773654841


   @shinrich is going to pull this internally and test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #7408: Reactivate accept_no_activity_timeout

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7408:
URL: https://github.com/apache/trafficserver/pull/7408#issuecomment-792375846


   [approve ci]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org