You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2023/04/27 22:08:42 UTC

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3317: fixes #3284 updates tablet locs using conditional mutations

ctubbsii commented on code in PR #3317:
URL: https://github.com/apache/accumulo/pull/3317#discussion_r1179727819


##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -398,9 +399,7 @@ ConditionalTabletMutator requireOperation(TabletOperation operation,
   /**
    * Convenience interface for handling conditional mutations with a status of UNKNOWN.
    */
-  interface UknownValidator {
-    boolean shouldAccept(TabletMetadata tabletMetadata);
-  }
+  interface UknownValidator extends Predicate<TabletMetadata> {}

Review Comment:
   Should this typo be fixed?
   
   ```suggestion
     interface UnknownValidator extends Predicate<TabletMetadata> {}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org