You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/30 08:50:45 UTC
[GitHub] [avro] martin-g commented on a diff in pull request #1833: AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#
martin-g commented on code in PR #1833:
URL: https://github.com/apache/avro/pull/1833#discussion_r958196081
##########
lang/csharp/src/apache/test/IO/JsonCodecTests.cs:
##########
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using NUnit.Framework;
+using System.IO;
+using System.Linq;
+using System.Text;
+using Avro.Generic;
+using Avro.IO;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+
+namespace Avro.Test
+{
+ using Decoder = Avro.IO.Decoder;
+ using Encoder = Avro.IO.Encoder;
+
+ /// <summary>
+ /// Tests the JsonEncoder and JsonDecoder.
+ /// </summary>
+ [TestFixture]
+ public class JsonCodecTests
+ {
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f2\": 10.4, \"f1\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s1\" ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s2\" ")]
+ [TestCase("{ \"type\": \"fixed\", \"name\": \"f\", \"size\": 5 }", "\"hello\"")]
+ [TestCase("{ \"type\": \"array\", \"items\": \"int\" }", "[ 10, 20, 30 ]")]
+ [TestCase("{ \"type\": \"map\", \"values\": \"int\" }", "{ \"k1\": 10, \"k2\": 20, \"k3\": 30 }")]
+ [TestCase("[ \"int\", \"long\" ]", "{ \"int\": 10 }")]
+ [TestCase("\"string\"", "\"hello\"")]
+ [TestCase("\"bytes\"", "\"hello\"")]
+ [TestCase("\"int\"", "10")]
+ [TestCase("\"long\"", "10")]
+ [TestCase("\"float\"", "10.0")]
+ [TestCase("\"double\"", "10.0")]
+ [TestCase("\"boolean\"", "true")]
+ [TestCase("\"boolean\"", "false")]
+ [TestCase("\"null\"", "null")]
+ public void TestJsonAllTypesValidValues(String schemaStr, String value)
+ {
+ Schema schema = Schema.Parse(schemaStr);
+ byte[] avroBytes = fromJsonToAvro(value, schema);
+
+ Assert.IsTrue(JToken.DeepEquals(JToken.Parse(value),
+ JToken.Parse(fromAvroToJson(avroBytes, schema, true))));
+ }
+
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f4\": 10.4, \"f3\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s3\" ")]
Review Comment:
```suggestion
[TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": [ \"s1\", \"s2\"] }", " \"s3\" ")]
```
##########
lang/csharp/src/apache/test/IO/JsonCodecTests.cs:
##########
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using NUnit.Framework;
+using System.IO;
+using System.Linq;
+using System.Text;
+using Avro.Generic;
+using Avro.IO;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+
+namespace Avro.Test
+{
+ using Decoder = Avro.IO.Decoder;
+ using Encoder = Avro.IO.Encoder;
+
+ /// <summary>
+ /// Tests the JsonEncoder and JsonDecoder.
+ /// </summary>
+ [TestFixture]
+ public class JsonCodecTests
+ {
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f2\": 10.4, \"f1\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s1\" ")]
Review Comment:
```suggestion
[TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": [ \"s1\", \"s2\"] }", " \"s1\" ")]
```
##########
lang/csharp/src/apache/test/IO/JsonCodecTests.cs:
##########
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using NUnit.Framework;
+using System.IO;
+using System.Linq;
+using System.Text;
+using Avro.Generic;
+using Avro.IO;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+
+namespace Avro.Test
+{
+ using Decoder = Avro.IO.Decoder;
+ using Encoder = Avro.IO.Encoder;
+
+ /// <summary>
+ /// Tests the JsonEncoder and JsonDecoder.
+ /// </summary>
+ [TestFixture]
+ public class JsonCodecTests
+ {
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f2\": 10.4, \"f1\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s1\" ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s2\" ")]
+ [TestCase("{ \"type\": \"fixed\", \"name\": \"f\", \"size\": 5 }", "\"hello\"")]
+ [TestCase("{ \"type\": \"array\", \"items\": \"int\" }", "[ 10, 20, 30 ]")]
+ [TestCase("{ \"type\": \"map\", \"values\": \"int\" }", "{ \"k1\": 10, \"k2\": 20, \"k3\": 30 }")]
+ [TestCase("[ \"int\", \"long\" ]", "{ \"int\": 10 }")]
+ [TestCase("\"string\"", "\"hello\"")]
+ [TestCase("\"bytes\"", "\"hello\"")]
+ [TestCase("\"int\"", "10")]
+ [TestCase("\"long\"", "10")]
+ [TestCase("\"float\"", "10.0")]
+ [TestCase("\"double\"", "10.0")]
+ [TestCase("\"boolean\"", "true")]
+ [TestCase("\"boolean\"", "false")]
+ [TestCase("\"null\"", "null")]
+ public void TestJsonAllTypesValidValues(String schemaStr, String value)
+ {
+ Schema schema = Schema.Parse(schemaStr);
+ byte[] avroBytes = fromJsonToAvro(value, schema);
+
+ Assert.IsTrue(JToken.DeepEquals(JToken.Parse(value),
+ JToken.Parse(fromAvroToJson(avroBytes, schema, true))));
+ }
+
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f4\": 10.4, \"f3\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s3\" ")]
+ [TestCase("{ \"type\": \"fixed\", \"name\": \"f\", \"size\": 10 }", "\"hello\"")]
+ [TestCase("{ \"type\": \"array\", \"items\": \"int\" }", "[ \"10\", \"20\", \"30\" ]")]
+ [TestCase("{ \"type\": \"map\", \"values\": \"int\" }", "{ \"k1\": \"10\", \"k2\": \"20\"}")]
+ [TestCase("[ \"int\", \"long\" ]", "10")]
+ [TestCase("\"string\"", "10")]
+ [TestCase("\"bytes\"", "10")]
+ [TestCase("\"int\"", "\"hi\"")]
+ [TestCase("\"long\"", "\"hi\"")]
+ [TestCase("\"float\"", "\"hi\"")]
+ [TestCase("\"double\"", "\"hi\"")]
+ [TestCase("\"boolean\"", "\"hi\"")]
+ [TestCase("\"boolean\"", "\"hi\"")]
+ [TestCase("\"null\"", "\"hi\"")]
+ public void TestJsonAllTypesInvalidValues(String schemaStr, String value)
+ {
+ Schema schema = Schema.Parse(schemaStr);
+ Assert.Throws<AvroTypeException>(() => fromJsonToAvro(value, schema));
+ }
+
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f2\": 10.4, \"f1")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", "s1")]
Review Comment:
```suggestion
[TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": [ \"s1\", \"s2\"] }", "s1")]
```
##########
lang/csharp/src/apache/test/IO/JsonCodecTests.cs:
##########
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using NUnit.Framework;
+using System.IO;
+using System.Linq;
+using System.Text;
+using Avro.Generic;
+using Avro.IO;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+
+namespace Avro.Test
+{
+ using Decoder = Avro.IO.Decoder;
+ using Encoder = Avro.IO.Encoder;
+
+ /// <summary>
+ /// Tests the JsonEncoder and JsonDecoder.
+ /// </summary>
+ [TestFixture]
+ public class JsonCodecTests
+ {
+ [TestCase("{ \"type\": \"record\", \"name\": \"r\", \"fields\": [ " +
+ " { \"name\" : \"f1\", \"type\": \"int\" }, " +
+ " { \"name\" : \"f2\", \"type\": \"float\" } " +
+ "] }",
+ "{ \"f2\": 10.4, \"f1\": 10 } ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s1\" ")]
+ [TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": " + "[ \"s1\", \"s2\"] }", " \"s2\" ")]
Review Comment:
```suggestion
[TestCase("{ \"type\": \"enum\", \"name\": \"e\", \"symbols\": [ \"s1\", \"s2\"] }", " \"s2\" ")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org