You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/12 09:59:14 UTC
[GitHub] [solr] uschindler opened a new pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …
uschindler opened a new pull request #261:
URL: https://github.com/apache/solr/pull/261
…conform to how Solr's build is setup (don't put logic of plugins into build.gradle files)
See: https://issues.apache.org/jira/browse/SOLR-15428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler merged pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …
Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #261:
URL: https://github.com/apache/solr/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a change in pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #261:
URL: https://github.com/apache/solr/pull/261#discussion_r688115052
##########
File path: solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java
##########
@@ -31,7 +30,7 @@
@Before
public void setup() {
- System.setProperty("randomSeed", Long.toString(new Random().nextLong()));
+ System.setProperty("randomSeed", Long.toString(random().nextLong()));
Review comment:
I didn't want to change the code so I just replaced the bad Random ctor.
I don't know what this property means and where it is used, so I left as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a change in pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #261:
URL: https://github.com/apache/solr/pull/261#discussion_r688115970
##########
File path: solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java
##########
@@ -31,7 +30,7 @@
@Before
public void setup() {
- System.setProperty("randomSeed", Long.toString(new Random().nextLong()));
+ System.setProperty("randomSeed", Long.toString(random().nextLong()));
Review comment:
In fact, it can't get worse when switching away from a new Random. 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #261:
URL: https://github.com/apache/solr/pull/261#discussion_r688073420
##########
File path: solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java
##########
@@ -31,7 +30,7 @@
@Before
public void setup() {
- System.setProperty("randomSeed", Long.toString(new Random().nextLong()));
+ System.setProperty("randomSeed", Long.toString(random().nextLong()));
Review comment:
Too bad `com.carrotsearch.randomizedtesting.RandomizedContext#getRunnerSeed` isn't public but any way it's not a big deal; the change here is fine. `com.carrotsearch.randomizedtesting.RandomizedContext#getRunnerSeedAsString` is public but it's hex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org