You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/02 17:41:51 UTC

Re: Review Request 58708: Checked validity of master and agent version numbers on startup.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58708/
-----------------------------------------------------------

(Updated May 2, 2017, 5:41 p.m.)


Review request for mesos, Benjamin Mahler and Kapil Arya.


Changes
-------

Address review comments.


Bugs: MESOS-6976
    https://issues.apache.org/jira/browse/MESOS-6976


Repository: mesos


Description
-------

During startup, we now check that the compiled-in version number of the
master and agent can be parsed by stout's `Version::parse` (i.e., that
`MESOS_VERSION` is valid according to stout's extended variant of the
Semver 2.0.0 format).


Diffs (updated)
-----

  src/master/main.cpp 462ed3229d15b157a92d96860503c06368ab21b7 
  src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52 


Diff: https://reviews.apache.org/r/58708/diff/3/

Changes: https://reviews.apache.org/r/58708/diff/2-3/


Testing
-------

`make check`


Thanks,

Neil Conway