You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/04 22:40:20 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new issue #5807: Proposal: Deprecate PQL
fx19880617 opened a new issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807
Pinot community,
Current Pinot supports two query syntaxes and endpoints: PQL and SQL:
PQL is the legacy implementation based on Antlr;
SQL implementation is based on CalciteSQL. It gives us more capabilities to implement functionalities in Pinot.
We are proposing to keep new query features only on SQL side and deprecate PQL by end of 2020.
A detailed plan of changes will follow.
All comments/feedbacks/concerns are welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-702984608
Just wanted to update this thread to state that we (LinkedIn) are targeting to migrate our users from PQL to SQL by Dec 2020, after which we would be ready to start deprecating PQL @fx19880617. Are there any other users out there who are still using PQL?
cc: @siddharthteotia @kishoreg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] yupeng9 commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
yupeng9 commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-782454963
+1 to what Ting suggested. Could we have a config to disable (and
deprecate) the endpoint first, with the default value disabled? So the
endpoint removal can be done together with the PQL cleanup.
Best,
On Fri, Feb 19, 2021 at 3:19 PM Ting Chen <no...@github.com> wrote:
> Uber still uses PQL extensively with a few hundred tables and dozens of
> use cases. It takes us time to move out of PQL. End of Feb is too tight for
> us to complete the migration process. Can you postpone the removal of the
> query endpoints at least to the end of June so that we can complete the
> migration? Or leave a backward compatible way for users to still query PQL
> endpoint for a while?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pinot/issues/5807#issuecomment-782443572>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADGNU2S2XZCHEVVMP5QYINTS73WZXANCNFSM4PU3UXVQ>
> .
>
--
--Yupeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-703198974
> Just wanted to update this thread to state that we (LinkedIn) are targeting to migrate our users from PQL to SQL by Dec 2020, after which we would be ready to start deprecating PQL @fx19880617. Are there any other users out there who are still using PQL?
>
> cc: @siddharthteotia @kishoreg
Glad to hear this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
siddharthteotia edited a comment on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-781713127
We can split this into 2 parts
PQL endpoint removal from broker and controller.
- The controller's query console endpoint (/pql) talks to broker's endpoint (/query).
- Remove any other public APIs for PQL.
PQL cleanup from the engine
- Remove Antlr parser
- Remove PQL2Compiler
- Don't convert PinotQueryToBrokerRequest: just pass PinotQuery inside BrokerRequest to server. Server can already handle it
- Cleanup combine operator and broker reduce operators that have different code paths for PQL and SQL.
- Cleanup tests to remove use of PQL compiler.
The first task of endpoint removal can be done by end of Feb. This will at least ensure no one can use PQL to query Pinot even though PQL exists in the engine. Cleanup of PQL from the engine can be a subsequent task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-781713127
We can split this into 2 parts
PQL endpoint removal from broker and controller.
- The controller's query console endpoint (/pql) talks to broker's endpoint (/query).
PQL cleanup from the engine
- Remove Antlr parser
- Remove PQL2Compiler
- Don't convert PinotQueryToBrokerRequest: just pass PinotQuery inside BrokerRequest to server. Server can already handle it
- Cleanup combine operator and broker reduce operators that have different code paths for PQL and SQL.
- Cleanup tests to remove use of PQL compiler.
The first task of endpoint removal can be done by end of Feb. This will at least ensure no one can use PQL to query Pinot even though PQL exists in the engine. Cleanup of PQL can be a subsequent task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] yupeng9 commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
yupeng9 commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-703010708
At Uber, we use Presto/Pinot connector and we plan to migrate to the SQL-based connector by the end of 2020.
+1 to using SQL onward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] chenboat commented on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
chenboat commented on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-782443572
Uber still uses PQL extensively with a few hundred tables and dozens of use cases. It takes us time to move out of PQL. End of Feb is too tight for us to complete the migration process. Can you postpone the removal of the query endpoints at least to the end of June so that we can complete the migration? Or leave a backward compatible way for users to still query PQL endpoint for a while?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #5807: Proposal: Deprecate PQL
Posted by GitBox <gi...@apache.org>.
siddharthteotia edited a comment on issue #5807:
URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-781713127
We can split this into 2 parts
PQL endpoint removal from broker and controller.
- The controller's query console endpoint (/pql) talks to broker's endpoint (/query).
PQL cleanup from the engine
- Remove Antlr parser
- Remove PQL2Compiler
- Don't convert PinotQueryToBrokerRequest: just pass PinotQuery inside BrokerRequest to server. Server can already handle it
- Cleanup combine operator and broker reduce operators that have different code paths for PQL and SQL.
- Cleanup tests to remove use of PQL compiler.
The first task of endpoint removal can be done by end of Feb. This will at least ensure no one can use PQL to query Pinot even though PQL exists in the engine. Cleanup of PQL from the engine can be a subsequent task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org