You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2024/06/14 12:23:25 UTC

(shardingsphere) branch master updated: Remove disable from FilePluginE2EIT (#31693)

This is an automated email from the ASF dual-hosted git repository.

zhonghongsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 3369dcc6a12 Remove disable from FilePluginE2EIT (#31693)
3369dcc6a12 is described below

commit 3369dcc6a12a3d1c7a81fcf13a3c4a71cd8da34e
Author: jiangML <10...@qq.com>
AuthorDate: Fri Jun 14 20:23:19 2024 +0800

    Remove disable from FilePluginE2EIT (#31693)
    
    * Remove disable from FilePluginE2EIT
    
    * Update file-advisors.yaml
---
 .../type/file/src/main/resources/META-INF/conf/file-advisors.yaml | 8 ++++++--
 .../shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java       | 2 --
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml b/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml
index 74b2d2496bf..546daeb77b7 100644
--- a/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml
+++ b/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml
@@ -22,5 +22,9 @@ advisors:
       - name: create
         type: method
         params:
-          - index: 3
-            type: java.util.Map
+          - index: 0
+            type: org.apache.shardingsphere.metadata.persist.MetaDataPersistService
+          - index: 1
+            type: org.apache.shardingsphere.mode.manager.ContextManagerBuilderParameter
+          - index: 2
+            type: org.apache.shardingsphere.infra.instance.ComputeNodeInstanceContext
diff --git a/test/e2e/agent/plugins/logging/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java b/test/e2e/agent/plugins/logging/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java
index 6dbaf1ebccb..7452b61a9f8 100644
--- a/test/e2e/agent/plugins/logging/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java
+++ b/test/e2e/agent/plugins/logging/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java
@@ -22,7 +22,6 @@ import org.apache.shardingsphere.test.e2e.agent.common.env.E2ETestEnvironment;
 import org.apache.shardingsphere.test.e2e.agent.file.asserts.ContentAssert;
 import org.apache.shardingsphere.test.e2e.agent.file.cases.IntegrationTestCasesLoader;
 import org.apache.shardingsphere.test.e2e.agent.file.cases.LogTestCase;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.condition.EnabledIf;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.ExtensionContext;
@@ -35,7 +34,6 @@ import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.assertFalse;
 
-@Disabled("Fix me by @jiangmaolin")
 @ExtendWith(AgentTestActionExtension.class)
 class FilePluginE2EIT {