You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 18:34:19 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #9015: Tai/fix info endpoint

nytai opened a new pull request #9015: Tai/fix info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The new dashboard list view https://github.com/apache/incubator-superset/pull/8845 depends on the info endpoint to generate filters and check permissions. It seems it was disabled in the recent work to remove unused routes. This PR re-enabled that endpoint for the rest apis.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - Dashboard List view works. 
   - `_info` endpoint does not error out on loading the dashboard list view. 
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @dpgaspar @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#issuecomment-578251699
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=h1) Report
   > Merging [#9015](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a85df65f85134901124830d9787c7ac15b6413e9?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9015/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9015   +/-   ##
   =======================================
     Coverage   59.15%   59.15%           
   =======================================
     Files         367      367           
     Lines       11682    11682           
     Branches     2864     2864           
   =======================================
     Hits         6910     6910           
     Misses       4593     4593           
     Partials      179      179
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=footer). Last update [a85df65...6a16f40](https://codecov.io/gh/apache/incubator-superset/pull/9015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#discussion_r370801498
 
 

 ##########
 File path: superset/constants.py
 ##########
 @@ -58,4 +59,4 @@ class RouteMethod:  # pylint: disable=too-few-public-methods
     # Commonly used sets
     CRUD_SET = {ADD, LIST, EDIT, DELETE, ACTION_POST}
     RELATED_VIEW_SET = {ADD, LIST, EDIT, DELETE}
-    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT}
+    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT, INFO}
 
 Review comment:
   We can remove it from the default and enable the info endpoint on a per-case basis. That was the original approach: https://github.com/apache/incubator-superset/pull/9015/commits/a5488e2aad8cc7b0daa95bc9382697dcc07a51b5
   but it seems like we'll need to info endpoint in most cases 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 merged pull request #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 edited a comment on issue #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
etr2460 edited a comment on issue #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#issuecomment-578358583
 
 
   @nytai can we either revert the breaking PR #8960 or merge this ASAP? The dashboard list view is now broken in master, and we're unable to deploy from master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#discussion_r370790236
 
 

 ##########
 File path: superset/constants.py
 ##########
 @@ -58,4 +59,4 @@ class RouteMethod:  # pylint: disable=too-few-public-methods
     # Commonly used sets
     CRUD_SET = {ADD, LIST, EDIT, DELETE, ACTION_POST}
     RELATED_VIEW_SET = {ADD, LIST, EDIT, DELETE}
-    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT}
+    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT, INFO}
 
 Review comment:
   I'm a little concerned with this pattern overall. Altering these "defaults" down the road could lead to unintended side effects.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#issuecomment-578358583
 
 
   Can we either revert the breaking PR #8960 or merge this ASAP? The dashboard list view is now broken in master, and we're unable to deploy from master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #9015: [dashboard] fix, enable info endpoint

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#issuecomment-578360892
 
 
   i'm going to merge this to unbreak master. We can make necessary fixes next week.
   
   I'm choosing this approach over reverting the API change PR as that one was tagged as a security PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org