You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/14 03:34:03 UTC
[GitHub] [shardingsphere] natehuangting opened a new pull request, #18346: add unit test assertLoadReplicaStatus for MySQLNormalReplicationDatabaseDiscoveryProviderAlgorithmTest
natehuangting opened a new pull request, #18346:
URL: https://github.com/apache/shardingsphere/pull/18346
Fixes #18338 .
Changes proposed in this pull request:
- add unit test assertLoadReplicaStatus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18346: add unit test assertLoadReplicaStatus for MySQLNormalReplicationDatabaseDiscoveryProviderAlgorithmTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18346:
URL: https://github.com/apache/shardingsphere/pull/18346#issuecomment-1154687295
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18346](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f049dba) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9534fa516742280caac6bdc4cc817b522449df3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9534fa5) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18346 +/- ##
============================================
+ Coverage 59.12% 59.14% +0.01%
Complexity 2194 2194
============================================
Files 3736 3736
Lines 54761 54761
Branches 9308 9308
============================================
+ Hits 32379 32386 +7
+ Misses 19630 19618 -12
- Partials 2752 2757 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTXlTUUxOb3JtYWxSZXBsaWNhdGlvbkRhdGFiYXNlRGlzY292ZXJ5UHJvdmlkZXJBbGdvcml0aG0uamF2YQ==) | `71.42% <0.00%> (+14.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9534fa5...f049dba](https://codecov.io/gh/apache/shardingsphere/pull/18346?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18346: add unit test assertLoadReplicaStatus for MySQLNormalReplicationDatabaseDiscoveryProviderAlgorithmTest
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18346:
URL: https://github.com/apache/shardingsphere/pull/18346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org