You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Patrick Hunt <ph...@apache.org> on 2011/05/20 18:17:19 UTC

Review Request: HIVE-2117: insert overwrite ignoring partition location

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/772/
-----------------------------------------------------------

Review request for hive and Carl Steinbach.


Summary
-------

This change resolves a regression introduced by HIVE-1707, specifically that the partition location (set via alter table partition location) is not being respected.

I addressed this by using the user specified location (as done originally), except in the case with cross-filesystem moves (which was the concern in 1707).


This addresses bug HIVE-2117.
    https://issues.apache.org/jira/browse/HIVE-2117


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 916b235 
  ql/src/test/org/apache/hadoop/hive/ql/BaseTestQueries.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 4685471 
  ql/src/test/org/apache/hadoop/hive/ql/TestLocationQueries.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/TestMTQueries.java 8c7c0b8 
  ql/src/test/queries/clientpositive/alter5.q PRE-CREATION 
  ql/src/test/results/clientpositive/alter5.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/772/diff


Testing
-------

I added a new test which verifies partition location explicitly - as the existing tests ignore this detail. This test failed w/o my fix applied, it passes with the fix applied.


Thanks,

Patrick