You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/17 09:29:52 UTC
[GitHub] [airflow] feluelle commented on a change in pull request #6100:
[AIRFLOW-5387] Fix show paused pagination bug
feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325068816
##########
File path: tests/www/test_utils.py
##########
@@ -103,14 +105,45 @@ def test_params_search(self):
self.assertEqual('search=bash_',
utils.get_params(search='bash_'))
- def test_params_showPaused_true(self):
- """Should detect True as default for showPaused"""
- self.assertEqual('',
- utils.get_params(showPaused=True))
-
- def test_params_showPaused_false(self):
- self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+ @parameterized.expand([
+ (True, False, ''),
+ (False, True, ''),
+ (True, True, 'showPaused=True'),
+ (False, False, 'showPaused=False'),
+ (None, True, ''),
+ (None, False, ''),
+ ])
+ def test_params_showPaused(self, show_paused, hide_by_default, expected_result):
+ os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = str(hide_by_default)
+
+ try:
+ self.assertEqual(expected_result,
+ utils.get_params(showPaused=show_paused))
+ finally:
+ del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
+
+ @parameterized.expand([
+ (True, False, True),
+ (False, True, True),
+ (True, True, False),
+ (False, False, False),
+ (None, True, True),
+ (None, False, True),
+ ])
+ def test_should_remove_show_paused_from_url_params(self, show_paused,
+ hide_by_default, expected_result):
+ os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = str(hide_by_default)
+
+ try:
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services