You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ctakes.apache.org by Alexandru Zbarcea <al...@apache.org> on 2017/10/02 12:17:58 UTC
CTAKES-460: coreference Test should not be part of main
Hi,
I have refactor a main class that should have been a UTest.
https://issues.apache.org/jira/browse/CTAKES-460
This moves the test code from src/main to src/test and also added some
refactoring.
No impact. Can easily be merged.
Alex
Re: CTAKES-460: coreference Test should not be part of main [EXTERNAL]
Posted by Alexandru Zbarcea <al...@apache.org>.
Thank you Tim
Alex
On Oct 2, 2017 10:43, "Miller, Timothy" <
Timothy.Miller@childrens.harvard.edu> wrote:
Thanks Alex, I've committed this patch.
I unfortunately looked at the wrong tab when typing my commit message
and committed it with the wrong issue number (459).
Tim
On Mon, 2017-10-02 at 08:17 -0400, Alexandru Zbarcea wrote:
> Hi,
>
> I have refactor a main class that should have been a UTest.
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_CTAKES-
> 2D460&d=DwIBaQ&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=Heup-
> IbsIg9Q1TPOylpP9FE4GTK-
> OqdTDRRNQXipowRLRjx0ibQrHEo8uYx6674h&m=T0fckwyf1n_TXQgdwCR5YlQItLlxMx
> 9nU_S5EUx1Iu0&s=f5ZcQqm3Dbk91cdhymh20-kg5cyZGoHPFjK0x9ZH32k&e=
>
> This moves the test code from src/main to src/test and also added
> some
> refactoring.
>
> No impact. Can easily be merged.
>
> Alex
Re: CTAKES-460: coreference Test should not be part of main
[EXTERNAL]
Posted by "Miller, Timothy" <Ti...@childrens.harvard.edu>.
Thanks Alex, I've committed this patch.
I unfortunately looked at the wrong tab when typing my commit message
and committed it with the wrong issue number (459).
Tim
On Mon, 2017-10-02 at 08:17 -0400, Alexandru Zbarcea wrote:
> Hi,
>
> I have refactor a main class that should have been a UTest.
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_CTAKES-
> 2D460&d=DwIBaQ&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=Heup-
> IbsIg9Q1TPOylpP9FE4GTK-
> OqdTDRRNQXipowRLRjx0ibQrHEo8uYx6674h&m=T0fckwyf1n_TXQgdwCR5YlQItLlxMx
> 9nU_S5EUx1Iu0&s=f5ZcQqm3Dbk91cdhymh20-kg5cyZGoHPFjK0x9ZH32k&e=
>
> This moves the test code from src/main to src/test and also added
> some
> refactoring.
>
> No impact. Can easily be merged.
>
> Alex