You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "YiwenWu (via GitHub)" <gi...@apache.org> on 2024/01/19 16:30:36 UTC
[PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
YiwenWu opened a new pull request, #3639:
URL: https://github.com/apache/calcite/pull/3639
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "JiajunBernoulli (via GitHub)" <gi...@apache.org>.
JiajunBernoulli commented on PR #3639:
URL: https://github.com/apache/calcite/pull/3639#issuecomment-1902552893
LGTM, thanks for your PR @YiwenWu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars commented on PR #3639:
URL: https://github.com/apache/calcite/pull/3639#issuecomment-1902036017
hi @YiwenWu Thanks for this work，Please improve the PR description and add isuse link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "macroguo-ghy (via GitHub)" <gi...@apache.org>.
macroguo-ghy merged PR #3639:
URL: https://github.com/apache/calcite/pull/3639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "tanclary (via GitHub)" <gi...@apache.org>.
tanclary commented on code in PR #3639:
URL: https://github.com/apache/calcite/pull/3639#discussion_r1459320707
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7704,6 +7703,101 @@ private void checkLiteral2(String expression, String expected) {
sql(query).withSpark().withLibrary(SqlLibrary.SPARK).ok(expectedSql);
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6213">[CALCITE-6213]
+ * The default behavior of NullCollation in Presto is LAST </a>.
+ */
+ @Test void testNullCollation() {
+ final String query = "select * from \"product\" order by \"brand_name\"";
+ final String expected = "SELECT *\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "ORDER BY \"brand_name\"";
+ final String sparkExpected = "SELECT *\n"
Review Comment:
I'm confused why we are also testing for Spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "YiwenWu (via GitHub)" <gi...@apache.org>.
YiwenWu commented on PR #3639:
URL: https://github.com/apache/calcite/pull/3639#issuecomment-1902487881
> hi @YiwenWu Thanks for this work，Please improve the PR description and add isuse link.
@XuQianJin-Stars Thank you for the code review, I added the description and link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6213] The default behavior of NullCollation in Presto is LAST [calcite]
Posted by "YiwenWu (via GitHub)" <gi...@apache.org>.
YiwenWu commented on code in PR #3639:
URL: https://github.com/apache/calcite/pull/3639#discussion_r1460131379
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7704,6 +7703,101 @@ private void checkLiteral2(String expression, String expected) {
sql(query).withSpark().withLibrary(SqlLibrary.SPARK).ok(expectedSql);
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6213">[CALCITE-6213]
+ * The default behavior of NullCollation in Presto is LAST </a>.
+ */
+ @Test void testNullCollation() {
+ final String query = "select * from \"product\" order by \"brand_name\"";
+ final String expected = "SELECT *\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "ORDER BY \"brand_name\"";
+ final String sparkExpected = "SELECT *\n"
Review Comment:
SparkSQL and Presto are commonly used in SQL-on-Hadoop frameworks. Previously, Presto was set to the value "LOW," which is consistent with Spark. This test demonstrates the comparative effect of setting null collation to "LAST."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org