You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/07 12:18:44 UTC
[GitHub] [sling-org-apache-sling-installer-factory-configuration] akankshajain18 opened a new pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
akankshajain18 opened a new pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] sonarcloud[bot] commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756108948
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100.png' alt='100.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=6&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] rombert commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756692694
Thanks for the PR @akankshajain18 , I've tweaked it slightly and pushed to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] rombert closed pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
rombert closed pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] akankshajain18 commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
akankshajain18 commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756715584
Thank you @rombert and @cziegeler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] rombert commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756692694
Thanks for the PR @akankshajain18 , I've tweaked it slightly and pushed to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] rombert closed pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
rombert closed pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] akankshajain18 commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
akankshajain18 commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756715584
Thank you @rombert and @cziegeler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] rombert commented on pull request #6: SLING-10043 - Naming OSGi configs with dashes breaks the OSGi installer
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/6#issuecomment-756122572
@cziegeler - code LGTM, but I have very little experience with the OSGi installer's inner workings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org