You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/10/28 15:17:32 UTC

Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13603
    https://issues.apache.org/jira/browse/AMBARI-13603


Repository: ambari


Description
-------

The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
does it really indicate. The ambari disk usage alerts are meant to check two
things: that you have have enough space total and percent free space in
/usr/hdp for data created by hadoop and for installing versioned RPMs. Total
free space alerts are something that you’ll probably want to fix since it
means you have less than a certain amount of total free space left.

Proposing the change...

Alert Name:  
**Host Disk Usage**

Description:  
**This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**


Diffs
-----

  ambari-server/docs/api/v1/alerts.md f2c50a8 
  ambari-server/src/main/resources/alerts.json 6a50223 
  ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
  ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
  ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
  ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 

Diff: https://reviews.apache.org/r/39720/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On Жов. 29, 2015, 3:30 після полудня, Vitalyi Brodetskyi wrote:
> > Ship It!

Please add unit test and please create constant if you are using some mothod more then one time.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104432
-----------------------------------------------------------


On Жов. 29, 2015, 3:27 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Жов. 29, 2015, 3:27 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a3d3c53 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104432
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Жов. 29, 2015, 3:27 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Жов. 29, 2015, 3:27 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a3d3c53 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104433
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Oct. 29, 2015, 11:27 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 11:27 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a3d3c53 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104912
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Лис. 3, 2015, 1:13 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Лис. 3, 2015, 1:13 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 2823a07 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b0dc5f1 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 1:13 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13603
    https://issues.apache.org/jira/browse/AMBARI-13603


Repository: ambari


Description
-------

The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
does it really indicate. The ambari disk usage alerts are meant to check two
things: that you have have enough space total and percent free space in
/usr/hdp for data created by hadoop and for installing versioned RPMs. Total
free space alerts are something that you’ll probably want to fix since it
means you have less than a certain amount of total free space left.

Proposing the change...

Alert Name:  
**Host Disk Usage**

Description:  
**This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**


Diffs (updated)
-----

  ambari-server/docs/api/v1/alerts.md f2c50a8 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 2823a07 
  ambari-server/src/main/resources/alerts.json 6a50223 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java b0dc5f1 
  ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
  ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
  ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
  ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 

Diff: https://reviews.apache.org/r/39720/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 3:27 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13603
    https://issues.apache.org/jira/browse/AMBARI-13603


Repository: ambari


Description
-------

The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
does it really indicate. The ambari disk usage alerts are meant to check two
things: that you have have enough space total and percent free space in
/usr/hdp for data created by hadoop and for installing versioned RPMs. Total
free space alerts are something that you’ll probably want to fix since it
means you have less than a certain amount of total free space left.

Proposing the change...

Alert Name:  
**Host Disk Usage**

Description:  
**This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**


Diffs (updated)
-----

  ambari-server/docs/api/v1/alerts.md f2c50a8 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java a3d3c53 
  ambari-server/src/main/resources/alerts.json 6a50223 
  ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
  ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
  ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
  ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 

Diff: https://reviews.apache.org/r/39720/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104303
-----------------------------------------------------------



ambari-server/src/main/resources/alerts.json (line 33)
<https://reviews.apache.org/r/39720/#comment162558>

    If you're changing the name, then you also need to remove the original alert since it will remain.


- Jonathan Hurley


On Oct. 28, 2015, 10:17 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 10:17 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 39720: Alerts: Rename "Ambari Agent Disk Usage" alert

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39720/#review104292
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Жов. 28, 2015, 2:17 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39720/
> -----------------------------------------------------------
> 
> (Updated Жов. 28, 2015, 2:17 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13603
>     https://issues.apache.org/jira/browse/AMBARI-13603
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert "Ambari Agent Disk Usage" is causing some confusion for users: what
> does it really indicate. The ambari disk usage alerts are meant to check two
> things: that you have have enough space total and percent free space in
> /usr/hdp for data created by hadoop and for installing versioned RPMs. Total
> free space alerts are something that you’ll probably want to fix since it
> means you have less than a certain amount of total free space left.
> 
> Proposing the change...
> 
> Alert Name:  
> **Host Disk Usage**
> 
> Description:  
> **This host-level alert is triggered if the amount of disk space used at /usr/hdp goes above specific thresholds. The default threshold values are 50% for WARNING and 80% for CRITICAL.**
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/alerts.md f2c50a8 
>   ambari-server/src/main/resources/alerts.json 6a50223 
>   ambari-web/app/assets/data/alerts/alertDefinitions.json 20d83bd 
>   ambari-web/app/assets/data/alerts/alert_instances.json 03ee7ce 
>   ambari-web/app/assets/data/alerts/alert_summary.json bbc8308 
>   ambari-web/test/mappers/alert_instances_mapper_test.js 2432749 
> 
> Diff: https://reviews.apache.org/r/39720/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>