You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/07/27 08:14:15 UTC
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2572
[CARBONDATA-2793][32k][Doc] Add 32k support in document
Update document and add description for long string columns
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0727_32k_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2572
----
commit 57d90c05b95bbd970ed911a3f2f0f6a1e7c82edf
Author: xuchuanyin <xu...@...>
Date: 2018-07-27T08:10:44Z
Add 32k support in document
Update document and add description for long string columns
----
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2572
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6086/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6411/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7670/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7680/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2572
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6031/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6362/
---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2572#discussion_r206455472
--- Diff: docs/data-management-on-carbondata.md ---
@@ -283,7 +283,30 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
```
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
-
+
+ - **String longer than 32000 characters** (Alpha Feature 1.4.1)
+
+ In common scenarios, the length of string is less than 32000, so carbondata store the length of content using Short to reduce memory and space consumption.
+ If your string content exceeds the 32000 characters limitation, you can specify the columns as 'long string column' using below tblProperties:
--- End diff --
OK
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6314/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7617/
---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2572#discussion_r206104005
--- Diff: docs/data-management-on-carbondata.md ---
@@ -283,7 +283,29 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
```
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
-
+
+ - **String longer than 32000 characters**
--- End diff --
OK
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2572
only document updated, no code related
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2572
retest this please
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by sgururajshetty <gi...@git.apache.org>.
Github user sgururajshetty commented on the issue:
https://github.com/apache/carbondata/pull/2572
LGTM
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2572
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6030/
---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
Posted by sgururajshetty <gi...@git.apache.org>.
Github user sgururajshetty commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2572#discussion_r206017345
--- Diff: docs/data-management-on-carbondata.md ---
@@ -283,7 +283,29 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
```
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
-
+
+ - **String longer than 32000 characters**
--- End diff --
If it is a Alpha feature then please mention in the bracket that (Alpha Feature 1.4.1 )
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6405/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2572
retest sdv please
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7677/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7560/
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2572
LGTM
---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2572
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7687/
---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2572
---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2572#discussion_r206416022
--- Diff: docs/data-management-on-carbondata.md ---
@@ -283,7 +283,30 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
```
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
-
+
+ - **String longer than 32000 characters** (Alpha Feature 1.4.1)
+
+ In common scenarios, the length of string is less than 32000, so carbondata store the length of content using Short to reduce memory and space consumption.
+ If your string content exceeds the 32000 characters limitation, you can specify the columns as 'long string column' using below tblProperties:
--- End diff --
comparing to previous paragram, better to describe we are using int32 to store length of the long string
---