You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/03/01 14:13:10 UTC
[GitHub] [celix] pnoltes opened a new pull request #322: Adds benchmark for dependency manager component
pnoltes opened a new pull request #322:
URL: https://github.com/apache/celix/pull/322
This PR adds a benchmark for creating, waiting for active and destroying a dependency manager component.
This is tested for both the C and C++ API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo edited a comment on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
Oipo edited a comment on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-788853405
~~Moreover, in Release mode asserts are NOPs, leading to another compilation error: `/home/oipo-unencrypted/Programming/celix-apache/libs/framework/include/celix/Trackers.h:407:59: error: unused parameter ‘voidSvc’ [-Werror=unused-parameter]`~~
Solved in https://github.com/apache/celix/pull/324/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes edited a comment on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
pnoltes edited a comment on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-789106045
> oipo@xanthos:/home/oipo-unencrypted/Programming/celix$ apt-cache show libbenchmark-dev
> Package: libbenchmark-dev
> Architecture: amd64
> Version: 1.5.0-4build1
I did not known libbenchmark-dev (aka microbenchmark == google benchmark).
Apparently the benchmark_main cmake target for current ubuntu version does not contain the main.
And I should take a break, because i fixed this in #324 instead of this PR..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo merged pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
Oipo merged pull request #322:
URL: https://github.com/apache/celix/pull/322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-789552589
Haha, alright. I'll approve both then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-789106045
> oipo@xanthos:/home/oipo-unencrypted/Programming/celix$ apt-cache show libbenchmark-dev
> Package: libbenchmark-dev
> Architecture: amd64
> Version: 1.5.0-4build1
I did not known libbenchmark-dev (aka microbenchmark == google benchmark).
Apparently the benchmark_main cmake target for current ubuntu version does not contain the main.
And I should take a break, because if fixed this in #324 instead of this PR..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-789087983
oipo@xanthos:/home/oipo-unencrypted/Programming/celix$ apt-cache show libbenchmark-dev
Package: libbenchmark-dev
Architecture: amd64
Version: 1.5.0-4build1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-788853405
Moreover, in Release mode asserts are NOPs, leading to another compilation error: `/home/oipo-unencrypted/Programming/celix-apache/libs/framework/include/celix/Trackers.h:407:59: error: unused parameter ‘voidSvc’ [-Werror=unused-parameter]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #322: Adds benchmark for dependency manager component
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #322:
URL: https://github.com/apache/celix/pull/322#issuecomment-789074691
> Missing `BENCHMARK_MAIN();` in one of the cc files prevents compilation on my machine.
The library benchmark::benchmark_main should add the main. Any idea which version of google benchmark you are using?
https://github.com/apache/celix/blob/feature/cmp_benchmark/libs/framework/benchmark/CMakeLists.txt#L33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org