You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/09/05 12:43:15 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #3408] [TEST] Remove the unstable flink process builder test case
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 17fc9f343 [KYUUBI #3408] [TEST] Remove the unstable flink process builder test case
17fc9f343 is described below
commit 17fc9f3431d3486a22aae696e101cd9f980f7e5d
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Mon Sep 5 20:43:05 2022 +0800
[KYUUBI #3408] [TEST] Remove the unstable flink process builder test case
### _Why are the changes needed?_
Fix https://github.com/apache/incubator-kyuubi/issues/3405
The test case is unstable, the result depends on whether we pre-build `kyuubi-flink-sql-engine` first, so we just remove it to avoid confusing users.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3408 from pan3793/test.
Closes #3408
0a7e430a [Cheng Pan] Remove the unstable flink process builder test case
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala
index 79f23c7c6..6c6ad7070 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala
@@ -24,7 +24,7 @@ import scala.collection.JavaConverters._
import scala.collection.immutable.ListMap
import scala.util.matching.Regex
-import org.apache.kyuubi.{KyuubiException, KyuubiFunSuite}
+import org.apache.kyuubi.KyuubiFunSuite
import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.config.KyuubiConf.{ENGINE_FLINK_EXTRA_CLASSPATH, ENGINE_FLINK_JAVA_OPTIONS, ENGINE_FLINK_MEMORY}
import org.apache.kyuubi.engine.flink.FlinkProcessBuilder._
@@ -94,12 +94,6 @@ class FlinkProcessBuilderSuite extends KyuubiFunSuite {
matchActualAndExpected(builder)
}
- test("all hadoop related environment variables are configured except FLINK_HADOOP_CLASSPATH") {
- assertThrows[KyuubiException](new FlinkProcessBuilder("vinoyang", conf) {
- override def env: Map[String, String] = envWithoutHadoopCLASSPATH
- })
- }
-
test("only FLINK_HADOOP_CLASSPATH environment variables are configured") {
val builder = new FlinkProcessBuilder("vinoyang", conf) {
override def env: Map[String, String] = envDefault +