[jira] [Commented] (LUCENE-6377) Pass previous reader to SearcherFactory

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386856#comment-14386856 ] 

Robert Muir commented on LUCENE-6377:
-------------------------------------

I think its fine. Docs already link to mergedSegmentWarmer (which is the ideal way to do this warming in most situations), but at the very least this solves the "first reader problem" (an annoyance with mergedSegmentWarmer IMO) because you will get passed null the first time, so you can warm everything. 

> Pass previous reader to SearcherFactory
> ---------------------------------------
>
>                 Key: LUCENE-6377
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6377
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 5.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6377.patch
>
>
> SearcherFactory is often used as advertised for warming segments for newly flushed segments or for searchers that are opened for the first time (generally where merge warmers don't apply). To make this simpler we should pass the previous reader to the factory as well to know what needs to be warmed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org