You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/04/07 05:30:06 UTC
[jira] [Created] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
HTablePool.putTable() should call table.flushCommits()
------------------------------------------------------
Key: HBASE-3750
URL: https://issues.apache.org/jira/browse/HBASE-3750
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.1
Reporter: Ted Yu
Assignee: Ted Yu
Currently HTablePool.putTable() doesn't call table.flushCommits()
This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018128#comment-13018128 ]
Gary Helmling commented on HBASE-3750:
--------------------------------------
Doc fix applied to trunk and 0.90 branch.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.3
>
> Attachments: 3750-addendum.patch, 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017970#comment-13017970 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review409
-----------------------------------------------------------
What is the motivation for calling flushCommits() automatically here? Are we trying to save client developers from writing buggy code?
The downside I see is that it's easy to envision a case where I use HTablePool for batch loading, but don't want to actually flush after every cycle of: get table, perform operation, return table. This change would prevent me from doing that and force me either write my own pool or somehow work around it.
In this case it both fails the obviousness test for me and limits what I can easily do as a developer. What is the upside? Is it sufficient to balance out the limitations?
/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
<https://reviews.apache.org/r/573/#comment793>
This seems dangerous and unexpected from a client code point of view. I wouldn't expect returning the table to a pool to throw a RuntimeException that could potentially cause my client application to exit.
- Gary
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018021#comment-13018021 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > What is the motivation for calling flushCommits() automatically here? Are we trying to save client developers from writing buggy code?
bq. >
bq. > The downside I see is that it's easy to envision a case where I use HTablePool for batch loading, but don't want to actually flush after every cycle of: get table, perform operation, return table. This change would prevent me from doing that and force me either write my own pool or somehow work around it.
bq. >
bq. > In this case it both fails the obviousness test for me and limits what I can easily do as a developer. What is the upside? Is it sufficient to balance out the limitations?
bq.
bq. Ted Yu wrote:
bq. This addition is certainly defensive.
bq. Consider what could happen before this patch, putTable() didn't guarantee that the table instance would be put back into the queue (because of size limit of the queue). The user would risk losing data.
bq. Since putTable(tableA) followed by getTable() call doesn't guarantee that tableA would be returned, I wonder how the user planned to finally flush all the buffered data to the underlying table. Consider, that getTable() would always return an HTableInterface instance, he/she couldn't just call getTable() repeatedly and flush the instance's (buffered) data.
bq.
bq. Gary Helmling wrote:
bq. I think the only necessary change here is your addition of the call to HTableFactory.releaseHTableInterface() when the table instance is being discarded. This calls HTable.close(), which of course calls flushCommits(), so there is no risk of data loss.
bq.
bq. flushCommits() is also called on each pooled table instance in HTablePool.closeTablePool(), again by way of HTable.close().
bq.
bq. Both of these seem appropriate.
bq.
bq. The only part in question, I think, is the additional call to flushCommits() on line 123. In the case of a discarded table, this is redundant. In the case of a table re-added to the pool, this limits flexibility and blocks some legitimate usage (putting back a table with a partially filled buffer). Of course this is debatable. There is no clear definition of which should take priority, telling HTable to not auto flush or putting a table back in the pool. But I would rather err on the side of flexibility and adaptability to different needs when the client already has the tools to flush when needed and we're already providing flushing when the table is discarded or the pool is closed.
bq.
bq. Ted Yu wrote:
bq. I modified title of the JIRA to narrow the scope.
bq. I am Okay with removing flushCommits() call since nobody complains about loss of data so far.
Ted, with the addition of the call to releaseHTableInterface() there is no data loss issue here. At least none beyond what is already possible by misusing HTable by calling setAutoFlush(false) and then never calling flushCommits() or close().
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java, line 126
bq. > <https://reviews.apache.org/r/573/diff/1/?file=15585#file15585line126>
bq. >
bq. > This seems dangerous and unexpected from a client code point of view. I wouldn't expect returning the table to a pool to throw a RuntimeException that could potentially cause my client application to exit.
bq.
bq. Ted Yu wrote:
bq. Disclaimer: I didn't invent this piece of code. I got it from HTableFactory.releaseHTableInterface()
bq. If we think that Lars' suggestion is good, we should accept this piece of code.
bq.
bq. Gary Helmling wrote:
bq. I think the issue is more that this is now being called in putTable() which doesn't declare itself to throw any exceptions.
bq.
bq. The solution seems pretty simple. Make putTable() and releaseHTableInterface() throw IOException and throw it directly instead of wrapping in RuntimeException.
bq.
bq. Ted Yu wrote:
bq. I agree with this suggestion, assuming this fix goes to both trunk and 0.90.3
bq. There're 3 methods which now throw IOException: closeTablePool(), putTable() and releaseHTableInterface()
bq.
bq. Once this proposal gets more votes, I will upload a new patch.
Hmm, I didn't realize this was targeted at 0.90 as well. Changing the API in 0.90 will not be acceptable. Let's leave the IOException handling in HTablePool.releaseHTableInterface() as is for this patch and open a new JIRA to change the API for trunk to throw IOException.
Yes, for the new JIRA, all three of those methods would need to be changed to throw IOException.
- Gary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review409
-----------------------------------------------------------
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling resolved HBASE-3750.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.90.3
Committed to trunk and 0.90 branch.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.3
>
> Attachments: 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017946#comment-13017946 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/
-----------------------------------------------------------
Review request for hbase and Lars George.
Summary
-------
Currently HTablePool.putTable() doesn't call table.flushCommits()
If AutoFlush is disabled for table instance, we should call table.flushCommits().
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
This addresses bug HBASE-3750.
https://issues.apache.org/jira/briwse/HBASE-3750
Diffs
-----
/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
Diff: https://reviews.apache.org/r/573/diff
Testing
-------
TestHTablePool passes.
Thanks,
Ted
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Attachment: (was: 3750.txt)
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Description:
Currently HTablePool.putTable() doesn't call table.flushCommits()
This may turn out to be surprise for users
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
was:
Currently HTablePool.putTable() doesn't call table.flushCommits()
This may turn out to be surprise for users
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018017#comment-13018017 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > What is the motivation for calling flushCommits() automatically here? Are we trying to save client developers from writing buggy code?
bq. >
bq. > The downside I see is that it's easy to envision a case where I use HTablePool for batch loading, but don't want to actually flush after every cycle of: get table, perform operation, return table. This change would prevent me from doing that and force me either write my own pool or somehow work around it.
bq. >
bq. > In this case it both fails the obviousness test for me and limits what I can easily do as a developer. What is the upside? Is it sufficient to balance out the limitations?
bq.
bq. Ted Yu wrote:
bq. This addition is certainly defensive.
bq. Consider what could happen before this patch, putTable() didn't guarantee that the table instance would be put back into the queue (because of size limit of the queue). The user would risk losing data.
bq. Since putTable(tableA) followed by getTable() call doesn't guarantee that tableA would be returned, I wonder how the user planned to finally flush all the buffered data to the underlying table. Consider, that getTable() would always return an HTableInterface instance, he/she couldn't just call getTable() repeatedly and flush the instance's (buffered) data.
I think the only necessary change here is your addition of the call to HTableFactory.releaseHTableInterface() when the table instance is being discarded. This calls HTable.close(), which of course calls flushCommits(), so there is no risk of data loss.
flushCommits() is also called on each pooled table instance in HTablePool.closeTablePool(), again by way of HTable.close().
Both of these seem appropriate.
The only part in question, I think, is the additional call to flushCommits() on line 123. In the case of a discarded table, this is redundant. In the case of a table re-added to the pool, this limits flexibility and blocks some legitimate usage (putting back a table with a partially filled buffer). Of course this is debatable. There is no clear definition of which should take priority, telling HTable to not auto flush or putting a table back in the pool. But I would rather err on the side of flexibility and adaptability to different needs when the client already has the tools to flush when needed and we're already providing flushing when the table is discarded or the pool is closed.
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java, line 126
bq. > <https://reviews.apache.org/r/573/diff/1/?file=15585#file15585line126>
bq. >
bq. > This seems dangerous and unexpected from a client code point of view. I wouldn't expect returning the table to a pool to throw a RuntimeException that could potentially cause my client application to exit.
bq.
bq. Ted Yu wrote:
bq. Disclaimer: I didn't invent this piece of code. I got it from HTableFactory.releaseHTableInterface()
bq. If we think that Lars' suggestion is good, we should accept this piece of code.
I think the issue is more that this is now being called in putTable() which doesn't declare itself to throw any exceptions.
The solution seems pretty simple. Make putTable() and releaseHTableInterface() throw IOException and throw it directly instead of wrapping in RuntimeException.
- Gary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review409
-----------------------------------------------------------
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018016#comment-13018016 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review412
-----------------------------------------------------------
/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
<https://reviews.apache.org/r/573/#comment796>
I think the issue is more that this is now being called in putTable() which doesn't declare itself to throw any exceptions.
The solution seems pretty simple. Make putTable() and releaseHTableInterface() throw IOException and throw it directly instead of wrapping in RuntimeException.
- Gary
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Attachment: 3750.txt
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018034#comment-13018034 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review415
-----------------------------------------------------------
Ship it!
Looks good. Thanks for the patch Ted!
- Gary
On 2011-04-10 04:18:50, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-10 04:18:50)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090659
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018020#comment-13018020 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > What is the motivation for calling flushCommits() automatically here? Are we trying to save client developers from writing buggy code?
bq. >
bq. > The downside I see is that it's easy to envision a case where I use HTablePool for batch loading, but don't want to actually flush after every cycle of: get table, perform operation, return table. This change would prevent me from doing that and force me either write my own pool or somehow work around it.
bq. >
bq. > In this case it both fails the obviousness test for me and limits what I can easily do as a developer. What is the upside? Is it sufficient to balance out the limitations?
bq.
bq. Ted Yu wrote:
bq. This addition is certainly defensive.
bq. Consider what could happen before this patch, putTable() didn't guarantee that the table instance would be put back into the queue (because of size limit of the queue). The user would risk losing data.
bq. Since putTable(tableA) followed by getTable() call doesn't guarantee that tableA would be returned, I wonder how the user planned to finally flush all the buffered data to the underlying table. Consider, that getTable() would always return an HTableInterface instance, he/she couldn't just call getTable() repeatedly and flush the instance's (buffered) data.
bq.
bq. Gary Helmling wrote:
bq. I think the only necessary change here is your addition of the call to HTableFactory.releaseHTableInterface() when the table instance is being discarded. This calls HTable.close(), which of course calls flushCommits(), so there is no risk of data loss.
bq.
bq. flushCommits() is also called on each pooled table instance in HTablePool.closeTablePool(), again by way of HTable.close().
bq.
bq. Both of these seem appropriate.
bq.
bq. The only part in question, I think, is the additional call to flushCommits() on line 123. In the case of a discarded table, this is redundant. In the case of a table re-added to the pool, this limits flexibility and blocks some legitimate usage (putting back a table with a partially filled buffer). Of course this is debatable. There is no clear definition of which should take priority, telling HTable to not auto flush or putting a table back in the pool. But I would rather err on the side of flexibility and adaptability to different needs when the client already has the tools to flush when needed and we're already providing flushing when the table is discarded or the pool is closed.
I modified title of the JIRA to narrow the scope.
I am Okay with removing flushCommits() call since nobody complains about loss of data so far.
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java, line 126
bq. > <https://reviews.apache.org/r/573/diff/1/?file=15585#file15585line126>
bq. >
bq. > This seems dangerous and unexpected from a client code point of view. I wouldn't expect returning the table to a pool to throw a RuntimeException that could potentially cause my client application to exit.
bq.
bq. Ted Yu wrote:
bq. Disclaimer: I didn't invent this piece of code. I got it from HTableFactory.releaseHTableInterface()
bq. If we think that Lars' suggestion is good, we should accept this piece of code.
bq.
bq. Gary Helmling wrote:
bq. I think the issue is more that this is now being called in putTable() which doesn't declare itself to throw any exceptions.
bq.
bq. The solution seems pretty simple. Make putTable() and releaseHTableInterface() throw IOException and throw it directly instead of wrapping in RuntimeException.
I agree with this suggestion, assuming this fix goes to both trunk and 0.90.3
There're 3 methods which now throw IOException: closeTablePool(), putTable() and releaseHTableInterface()
Once this proposal gets more votes, I will upload a new patch.
- Ted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review409
-----------------------------------------------------------
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Attachment: 3750-addendum.patch
There may be asymmetry for the use case Gary mentioned with table pool whose maxSize is not Integer.MAX_VALUE.
Namely putTable() sometimes flushes the buffer (for discarded table), sometimes not.
It would be hard for the user to debug the above situation.
This patch updates javadoc.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.3
>
> Attachments: 3750-addendum.patch, 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Attachment: 3750.txt
Added check for isAutoFlush() before calling flushCommits()
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-3750:
---------------------------------
Attachment: 3750-v2.patch
Patch committed to trunk and branch
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017954#comment-13017954 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review408
-----------------------------------------------------------
Reviewing just to see where my review is sent by reviews.apache.org
- Michael
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016685#comment-13016685 ]
stack commented on HBASE-3750:
------------------------------
Do you think this the way to go Ted? How you think people use the HTablePool? I'd think they'd check out an HTable instance, add an edit, then check it back in? If this is the case, then we'll flush each single edit. Or, do you think folks check out HTable instance, keep it around a while putting multiple edits on it and only then check it back in perhaps not using it again?
I wonder if a warning up in javadoc that we do NOT flush on return to the pool, so client needs to would be a better way to go?
I'm not sure.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018003#comment-13018003 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > What is the motivation for calling flushCommits() automatically here? Are we trying to save client developers from writing buggy code?
bq. >
bq. > The downside I see is that it's easy to envision a case where I use HTablePool for batch loading, but don't want to actually flush after every cycle of: get table, perform operation, return table. This change would prevent me from doing that and force me either write my own pool or somehow work around it.
bq. >
bq. > In this case it both fails the obviousness test for me and limits what I can easily do as a developer. What is the upside? Is it sufficient to balance out the limitations?
This addition is certainly defensive.
Consider what could happen before this patch, putTable() didn't guarantee that the table instance would be put back into the queue (because of size limit of the queue). The user would risk losing data.
Since putTable(tableA) followed by getTable() call doesn't guarantee that tableA would be returned, I wonder how the user planned to finally flush all the buffered data to the underlying table. Consider, that getTable() would always return an HTableInterface instance, he/she couldn't just call getTable() repeatedly and flush the instance's (buffered) data.
bq. On 2011-04-09 22:05:45, Gary Helmling wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java, line 126
bq. > <https://reviews.apache.org/r/573/diff/1/?file=15585#file15585line126>
bq. >
bq. > This seems dangerous and unexpected from a client code point of view. I wouldn't expect returning the table to a pool to throw a RuntimeException that could potentially cause my client application to exit.
Disclaimer: I didn't invent this piece of code. I got it from HTableFactory.releaseHTableInterface()
If we think that Lars' suggestion is good, we should accept this piece of code.
- Ted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review409
-----------------------------------------------------------
On 2011-04-09 19:48:31, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 19:48:31)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTablePool.putTable() doesn't call table.flushCommits()
bq. If AutoFlush is disabled for table instance, we should call table.flushCommits().
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3750:
--------------------------
Description:
Currently HTablePool.putTable() doesn't call table.flushCommits()
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
was:
Currently HTablePool.putTable() doesn't call table.flushCommits()
This may turn out to be surprise for users
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
Summary: HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table (was: HTablePool.putTable() should call table.flushCommits())
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
table.flushCommits()
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016691#comment-13016691 ]
Ted Yu commented on HBASE-3750:
-------------------------------
Thanks for the review Stack.
I attached modified version.
I think if the user turns off AutoFlush, we have a reason to flush for them. We can also poll the user mailinglist to see their pattern.
Looking at javadoc:
{code}
* Once you are done with it, return it to the pool with {@link #putTable(HTableInterface)}.
{code}
I don't think putting a single edit means 'done' with the table instance unless there was really just one edit.
> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018052#comment-13018052 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/#review416
-----------------------------------------------------------
Ship it!
That's exactly what I meant. Thanks Ted.
Also thank you for removing the obsolete imports.
- Lars
On 2011-04-10 04:18:50, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-10 04:18:50)
bq.
bq.
bq. Review request for hbase and Lars George.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
bq.
bq.
bq. This addresses bug HBASE-3750.
bq. https://issues.apache.org/jira/browse/HBASE-3750
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090659
bq.
bq. Diff: https://reviews.apache.org/r/573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool passes.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.3
>
> Attachments: 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018775#comment-13018775 ]
Hudson commented on HBASE-3750:
-------------------------------
Integrated in HBase-TRUNK #1846 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1846/])
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.90.3
>
> Attachments: 3750-addendum.patch, 3750-v2.patch, 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3750) HTablePool.putTable() should call
tableFactory.releaseHTableInterface() for discarded table
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018022#comment-13018022 ]
jiraposter@reviews.apache.org commented on HBASE-3750:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/
-----------------------------------------------------------
(Updated 2011-04-10 04:18:50.350005)
Review request for hbase and Lars George.
Changes
-------
I only kept the call to tableFactory.releaseHTableInterface()
Summary (updated)
-------
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
This addresses bug HBASE-3750.
https://issues.apache.org/jira/browse/HBASE-3750
Diffs (updated)
-----
/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090659
Diff: https://reviews.apache.org/r/573/diff
Testing
-------
TestHTablePool passes.
Thanks,
Ted
> HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-3750
> URL: https://issues.apache.org/jira/browse/HBASE-3750
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.1
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira