[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1364: PHOENIX-6596 Schema extraction double quotes expressions, resulting i…

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #1364:
URL: https://github.com/apache/phoenix/pull/1364#discussion_r769828723



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/tool/SchemaExtractionProcessor.java
##########
@@ -184,21 +184,39 @@ private String getIndexedColumnsString(PTable indexPTable, PTable dataPTable, St
     }
 
     private String extractIndexColumn(String columnName, String defaultCF) {
+        if (columnName == null) {
+            return null;
+        }
         String [] columnNameSplit = columnName.split(":");
         if(columnNameSplit[0].equals("") || columnNameSplit[0].equalsIgnoreCase(defaultCF) ||
                 (defaultCF.startsWith("L#") && columnNameSplit[0].equalsIgnoreCase(defaultCF.substring(2)))) {
-            return SchemaUtil.formatColumnName(columnNameSplit[1]);
+            return formatColumnOrExpression(columnNameSplit[1]);
         } else {
             if (columnNameSplit.length > 1) {
                 String schema = SchemaUtil.formatSchemaName(columnNameSplit[0]);
                 String name = SchemaUtil.formatColumnName(columnNameSplit[1]);
                 return String.format("%s.%s", schema, name);
             } else {
-                return SchemaUtil.formatColumnName(columnNameSplit[0]);
+                return formatColumnOrExpression(columnNameSplit[0]);
             }
         }
     }
 
+    private String formatColumnOrExpression(String columnOrExpression) {
+        System.out.println("columnOrExpressioncolumnOrExpressioncolumnOrExpression");

Review comment:
       Please remove the System.out.printlns




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org