You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/02/02 20:04:04 UTC
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/479
CB-10503: Documentation link points to 'latest' version even in latest buils
Fixed the link to point to dev version of the docs in development
@dblotsky @riknoll @rakatyal @nikhilkh Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-docs CB-10503
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 9c8f9b999ce13c8615e8b80929c331bf9ec41786
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-02-02T19:02:31Z
CB-10503: Documentation link points to 'latest' version even in latest build
Fixed the link to point to dev version of the docs in development
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178871753
We have another variable, `latest_docs_version`, whose name sounds like this one. Please rename this variable to something more explicit (like `default_linked_docs_version`) and please add it above [this line][line] so that it's grouped with the other one.
[line]: https://github.com/apache/cordova-docs/blob/master/_config.yml#L22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178764725
@riknoll Fixed the spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/479#discussion_r51617878
--- Diff: _config.yml ---
@@ -9,6 +9,7 @@ title: Apache Cordova
title_suffix: "Apache Cordova"
url: "https://cordova.apache.org" # the base hostname & protocol
baseurl: "" # the subpath of the site, e.g. /blog; NOTE: no trailing slash
+docsversion: "latest"
--- End diff --
Whitespace is weird here. Otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/479#issuecomment-178872081
+1 to @dblotsky's comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org