[GitHub] heyile commented on a change in pull request #1083: [SCB-1144]change samples use log4j2

[GitBox <gi...@apache.org>]

heyile commented on a change in pull request #1083: [SCB-1144]change samples use log4j2
URL: https://github.com/apache/servicecomb-java-chassis/pull/1083#discussion_r253352022
 
 

 ##########
 File path: samples/auth-sample/auth-consumer/pom.xml
 ##########
 @@ -29,6 +29,12 @@
     <dependency>
       <groupId>org.apache.servicecomb</groupId>
       <artifactId>transport-highway</artifactId>
+      <exclusions>
 
 Review comment:
   of course. If do not  have this ...
   the log is as bellow.
   ```
   log4j:WARN No appenders could be found for logger (org.springframework.core.env.StandardEnvironment).
   log4j:WARN Please initialize the log4j system properly.
   log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services