You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Michael Mosmann <mi...@mosmann.de> on 2013/11/13 08:09:12 UTC
code coverage maven plugin
Hi,
I did a minor change on master and configured jacoco for code coverage
reports. To enable coverage reports you can simply call:
mvn clean install -Pcoverage
I do NOT think that code coverage tells you something useful on its own,
it think it could help to identify some parts of our code where we
should write a little bit more tests.
Because I did not measured a big difference with and without coverage
enabled, I would prefer to switch it on as default. But I am not sure if
it breaks anything else.
Michael
Re: code coverage maven plugin
Posted by Michael Mosmann <mi...@mosmann.de>.
Am 13.11.13 13:08, schrieb Martin Grigorov:
> -Pfast suppresses javadoc and source plugins and doesn't execute the slow
> tests
ah.. ok.. so we should leave it off as default until we know where the
25% come from..
I will look for hotspots the following days and will write some tests.
mm:)
Re: code coverage maven plugin
Posted by Martin Grigorov <mg...@apache.org>.
-Pfast suppresses javadoc and source plugins and doesn't execute the slow
tests
On Wed, Nov 13, 2013 at 2:04 PM, Sven Meier <sv...@meiers.net> wrote:
> > -Pfast
>
> See the "fast" profile in wicket-parent's pom.
>
> Sven
>
>
>
> On 11/13/2013 01:01 PM, Michael Mosmann wrote:
>
>> Am 13.11.13 09:42, schrieb Martin Grigorov:
>>
>>> Just tested here:
>>> - mvn install -Pfast -Pcoverage => 1.40min (+- 3 secs)
>>> - mvn install -Pfast => 1.05min (+- 1sec)
>>>
>> what does -Pfast?
>>
>>>
>>> On Wed, Nov 13, 2013 at 10:36 AM, Sven Meier <sv...@meiers.net> wrote:
>>>
>>> Hi Michael,
>>>>
>>>> with coverage enabled the built takes 25% longer here. Why enable it by
>>>> default?
>>>>
>>> if it takes 25% more time we should not enable it by default..
>>
>> mm:)
>>
>>
>
Re: code coverage maven plugin
Posted by Sven Meier <sv...@meiers.net>.
> -Pfast
See the "fast" profile in wicket-parent's pom.
Sven
On 11/13/2013 01:01 PM, Michael Mosmann wrote:
> Am 13.11.13 09:42, schrieb Martin Grigorov:
>> Just tested here:
>> - mvn install -Pfast -Pcoverage => 1.40min (+- 3 secs)
>> - mvn install -Pfast => 1.05min (+- 1sec)
> what does -Pfast?
>>
>> On Wed, Nov 13, 2013 at 10:36 AM, Sven Meier <sv...@meiers.net> wrote:
>>
>>> Hi Michael,
>>>
>>> with coverage enabled the built takes 25% longer here. Why enable it by
>>> default?
> if it takes 25% more time we should not enable it by default..
>
> mm:)
>
Re: code coverage maven plugin
Posted by Michael Mosmann <mi...@mosmann.de>.
Am 13.11.13 09:42, schrieb Martin Grigorov:
> Just tested here:
> - mvn install -Pfast -Pcoverage => 1.40min (+- 3 secs)
> - mvn install -Pfast => 1.05min (+- 1sec)
what does -Pfast?
>
> On Wed, Nov 13, 2013 at 10:36 AM, Sven Meier <sv...@meiers.net> wrote:
>
>> Hi Michael,
>>
>> with coverage enabled the built takes 25% longer here. Why enable it by
>> default?
if it takes 25% more time we should not enable it by default..
mm:)
Re: code coverage maven plugin
Posted by Martin Grigorov <mg...@apache.org>.
Just tested here:
- mvn install -Pfast -Pcoverage => 1.40min (+- 3 secs)
- mvn install -Pfast => 1.05min (+- 1sec)
On Wed, Nov 13, 2013 at 10:36 AM, Sven Meier <sv...@meiers.net> wrote:
> Hi Michael,
>
> with coverage enabled the built takes 25% longer here. Why enable it by
> default?
>
> Sven
>
>
> On 11/13/2013 08:09 AM, Michael Mosmann wrote:
>
>> Hi,
>>
>> I did a minor change on master and configured jacoco for code coverage
>> reports. To enable coverage reports you can simply call:
>>
>> mvn clean install -Pcoverage
>>
>> I do NOT think that code coverage tells you something useful on its own,
>> it think it could help to identify some parts of our code where we should
>> write a little bit more tests.
>>
>> Because I did not measured a big difference with and without coverage
>> enabled, I would prefer to switch it on as default. But I am not sure if it
>> breaks anything else.
>>
>> Michael
>>
>>
>
Re: code coverage maven plugin
Posted by Sven Meier <sv...@meiers.net>.
Hi Michael,
with coverage enabled the built takes 25% longer here. Why enable it by
default?
Sven
On 11/13/2013 08:09 AM, Michael Mosmann wrote:
> Hi,
>
> I did a minor change on master and configured jacoco for code coverage
> reports. To enable coverage reports you can simply call:
>
> mvn clean install -Pcoverage
>
> I do NOT think that code coverage tells you something useful on its
> own, it think it could help to identify some parts of our code where
> we should write a little bit more tests.
>
> Because I did not measured a big difference with and without coverage
> enabled, I would prefer to switch it on as default. But I am not sure
> if it breaks anything else.
>
> Michael
>