You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:32:54 UTC
[GitHub] [rocketmq] lwclover opened a new issue, #4223: Delete repeated calls in MQClientInstance.start
lwclover opened a new issue, #4223:
URL: https://github.com/apache/rocketmq/issues/4223
Delete repeated calls in MQClientInstance.start, It triggers a Heartbeat and an extra timer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover closed issue #4223: Delete repeated calls in MQClientInstance.start
URL: https://github.com/apache/rocketmq/issues/4223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB commented on issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on issue #4223:
URL: https://github.com/apache/rocketmq/issues/4223#issuecomment-1113948642
You said "repeated" call, but I don't get it. Where is another call for `this.defaultMQProducer.getDefaultMQProducerImpl().start(false)`?
--------------------
你提到了“重复调用”，但是重复调用start的地方在哪里呀？这里的producer.start 起来是为了consumer客户端可以将消费失败的消息发送回broker，并没有重复吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover commented on issue #4223:
URL: https://github.com/apache/rocketmq/issues/4223#issuecomment-1112853116
> This defaultMQProducer is necessary for message sending back to broker. and **start** method will not invoke MQClientInstance#start, because it's parameter is false. and It is a producer, so heat heat and scheduled task should have like other normal producer.
>
> That is my opinion.
This line:
this.defaultMQProducer.getDefaultMQProducerImpl().start(false).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #4223:
URL: https://github.com/apache/rocketmq/issues/4223#issuecomment-1113944817
> > This defaultMQProducer is necessary for message sending back to broker. and **start** method will not invoke MQClientInstance#start, because it's parameter is false. and It is a producer, so heat heat and scheduled task should have like other normal producer.
> > That is my opinion.
>
> I mean this line in MQClientInstance#start: this.defaultMQProducer.getDefaultMQProducerImpl().start(false).
yeah, I watched your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover closed issue #4223: Delete repeated calls in MQClientInstance.start
URL: https://github.com/apache/rocketmq/issues/4223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover commented on issue #4223:
URL: https://github.com/apache/rocketmq/issues/4223#issuecomment-1118073214
DefaultMQProducer starts as follows:
DefaultMQProducer.start() -> DefaultMQProducerImpl.start() -> DefaultMQProducerImpl.start(true) -> MQClientInstance.start() -> DefaultMQProducerImpl.start(false).
In DefaultMQProducerImpl.start(false) call
```
this.mQClientFactory.sendHeartbeatToAllBrokerWithLock();
RequestFutureHolder.getInstance().startScheduledTask(this);
```
DefaultMQProducerImpl.start(true) call again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #4223: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #4223:
URL: https://github.com/apache/rocketmq/issues/4223#issuecomment-1112811595
This defaultMQProducer is necessary for message sending back to broker.
and **start** method will not invoke MQClientInstance#start, because it's parameter is false.
and It is a producer, so heat heat and scheduled task should have like other normal producer.
This is my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org