You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by Alexander Saydakov <sa...@yahooinc.com.INVALID> on 2022/06/27 22:22:41 UTC
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 3.5.0-rc1
Added PyPI artifacts since we distribute them through pypi.org
https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/pypi/
Sorry for not having them prepared upfront.
On Fri, Jun 24, 2022 at 8:01 AM David Cromberge <dc...@apache.org>
wrote:
> +1
>
> I checked:
> - GPG signature
> - SHA checksum
> - cmake, build and test cpp
> - local cpp install
> - build and test python
> - local python package install
> - LICENSE, README and NOTICE file present
>
> David
>
> On 2022/06/22 00:21:34 Alexander Saydakov wrote:
> > Hello Apache DataSketches PMC and Community,
> >
> >
> > This is a call for vote to release Apache DataSketches-cpp candidate
> > version: 3.5.0-rc1
> >
> >
> > Changes since datasketches-cpp 3.4.0 release
> > - Type converting constructors for KLL and REQ sketches
> > - Fixed KLL copy constructor (affects non-arithmetic types)
> > - Added internal check in CPC sketch compression to avoid problems with
> > static analysis
> >
> >
> > Source repository:
> >
> > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIhGU_MnQ$
> >
> >
> > Git Tag for this release:
> >
> > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/tree/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIuipl9aw$
> > <
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrLL1OnRcQ$
> > on
> > branch 3.5.x
> >
> >
> > Git HashId for this release is: 2ce1f160f423c4636bb7f7e7fa015fbad7294e2e
> >
> >
> > The Release Candidate Dist (Zip Repository):
> >
> > -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJvV8xilg$
> >
> >
> > The public signing key can be found in the KEYS file:
> >
> > -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJ0YXr_3Q$
> >
> >
> >
> > The artifacts have been signed with key:
> >
> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > alsay@apache.org>
> >
> >
> > Build & Test Guide:
> >
> > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIq4PdQBA$
> >
> >
> > The vote will be performed as follows:
> >
> > - This letter will be published on dev@ and remain open for at least
> 72
> > hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or
> > a majority of (+1) PMC votes are acquired. Anyone in the community can
> vote.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > Thanks,
> >
> > Alexander Saydakov
> >
> > alsay@apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 3.5.0-rc1
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
We have 3 positive binding votes and plenty of time to cast them. Please
consider this vote closed. We will proceed with this release.
Thank you.
On Tue, Jul 12, 2022 at 1:11 PM leerho <le...@gmail.com> wrote:
> +1 (binding)
> I checked:
> - cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
> - cmake --build build/Release -t all test //passed all tests
> - python3 -m pip install .
> - python/python3 import datasketches
> - tox //all tests passed
> - Checked LICENSE and NOTICE
> - Checked git.properties
>
> Lee.
>
> On Wed, Jun 29, 2022 at 12:40 AM Jon Malkin <jo...@gmail.com> wrote:
>
>> +1
>>
>> I checked
>> - signature and shasum
>> - followed build, test, and install instructions for linux
>> - tox
>> - checked signatures and shasum for all pypi files
>>
>> I decided to try building an install package, too, which is a .deb for my
>> linux box. That failed with a message about a few additional fields needing
>> to be specified. They can be done on teh command line. but it's probably
>> worth debating adding them to the cmake file. I'm not sure the correct
>> approach here.
>>
>> jon
>>
>>
>> On Mon, Jun 27, 2022 at 3:23 PM Alexander Saydakov
>> <sa...@yahooinc.com.invalid> wrote:
>>
>>> Added PyPI artifacts since we distribute them through pypi.org
>>> <https://urldefense.com/v3/__http://pypi.org__;!!Op6eflyXZCqGR5I!Ff-NX_ACj84Sj-BMjXJRPCnaP6l34525oFWNOGd9sMVL07ogQ_ZeR5j_nspHBEcnXsaUTEaJcC_htiQ$>
>>> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/pypi/
>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/pypi/__;!!Op6eflyXZCqGR5I!Ff-NX_ACj84Sj-BMjXJRPCnaP6l34525oFWNOGd9sMVL07ogQ_ZeR5j_nspHBEcnXsaUTEaJnw1e91I$>
>>> Sorry for not having them prepared upfront.
>>>
>>> On Fri, Jun 24, 2022 at 8:01 AM David Cromberge <dc...@apache.org>
>>> wrote:
>>>
>>>> +1
>>>>
>>>> I checked:
>>>> - GPG signature
>>>> - SHA checksum
>>>> - cmake, build and test cpp
>>>> - local cpp install
>>>> - build and test python
>>>> - local python package install
>>>> - LICENSE, README and NOTICE file present
>>>>
>>>> David
>>>>
>>>> On 2022/06/22 00:21:34 Alexander Saydakov wrote:
>>>> > Hello Apache DataSketches PMC and Community,
>>>> >
>>>> >
>>>> > This is a call for vote to release Apache DataSketches-cpp candidate
>>>> > version: 3.5.0-rc1
>>>> >
>>>> >
>>>> > Changes since datasketches-cpp 3.4.0 release
>>>> > - Type converting constructors for KLL and REQ sketches
>>>> > - Fixed KLL copy constructor (affects non-arithmetic types)
>>>> > - Added internal check in CPC sketch compression to avoid problems
>>>> with
>>>> > static analysis
>>>> >
>>>> >
>>>> > Source repository:
>>>> >
>>>> > -
>>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIhGU_MnQ$
>>>> >
>>>> >
>>>> > Git Tag for this release:
>>>> >
>>>> > -
>>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/tree/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIuipl9aw$
>>>> > <
>>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrLL1OnRcQ$
>>>> > on
>>>> > branch 3.5.x
>>>> >
>>>> >
>>>> > Git HashId for this release is:
>>>> 2ce1f160f423c4636bb7f7e7fa015fbad7294e2e
>>>> >
>>>> >
>>>> > The Release Candidate Dist (Zip Repository):
>>>> >
>>>> > -
>>>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJvV8xilg$
>>>> >
>>>> >
>>>> > The public signing key can be found in the KEYS file:
>>>> >
>>>> > -
>>>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJ0YXr_3Q$
>>>> >
>>>> >
>>>> >
>>>> > The artifacts have been signed with key:
>>>> >
>>>> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING
>>>> KEY) <
>>>> > alsay@apache.org>
>>>> >
>>>> >
>>>> > Build & Test Guide:
>>>> >
>>>> > -
>>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIq4PdQBA$
>>>> >
>>>> >
>>>> > The vote will be performed as follows:
>>>> >
>>>> > - This letter will be published on dev@ and remain open for at
>>>> least 72
>>>> > hours (excluding weekends and holidays), AND until at least 3 (+1)
>>>> PMC votes or
>>>> > a majority of (+1) PMC votes are acquired. Anyone in the community
>>>> can vote.
>>>> >
>>>> >
>>>> > Please vote accordingly:
>>>> >
>>>> >
>>>> > [ ] +1 approve
>>>> >
>>>> > [ ] +0 no opinion
>>>> >
>>>> > [ ] -1 disapprove with the reason
>>>> >
>>>> >
>>>> > Thanks,
>>>> >
>>>> > Alexander Saydakov
>>>> >
>>>> > alsay@apache.org
>>>> >
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
>>>> For additional commands, e-mail: dev-help@datasketches.apache.org
>>>>
>>>>
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 3.5.0-rc1
Posted by leerho <le...@gmail.com>.
+1 (binding)
I checked:
- cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
- cmake --build build/Release -t all test //passed all tests
- python3 -m pip install .
- python/python3 import datasketches
- tox //all tests passed
- Checked LICENSE and NOTICE
- Checked git.properties
Lee.
On Wed, Jun 29, 2022 at 12:40 AM Jon Malkin <jo...@gmail.com> wrote:
> +1
>
> I checked
> - signature and shasum
> - followed build, test, and install instructions for linux
> - tox
> - checked signatures and shasum for all pypi files
>
> I decided to try building an install package, too, which is a .deb for my
> linux box. That failed with a message about a few additional fields needing
> to be specified. They can be done on teh command line. but it's probably
> worth debating adding them to the cmake file. I'm not sure the correct
> approach here.
>
> jon
>
>
> On Mon, Jun 27, 2022 at 3:23 PM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
>> Added PyPI artifacts since we distribute them through pypi.org
>> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/pypi/
>> Sorry for not having them prepared upfront.
>>
>> On Fri, Jun 24, 2022 at 8:01 AM David Cromberge <dc...@apache.org>
>> wrote:
>>
>>> +1
>>>
>>> I checked:
>>> - GPG signature
>>> - SHA checksum
>>> - cmake, build and test cpp
>>> - local cpp install
>>> - build and test python
>>> - local python package install
>>> - LICENSE, README and NOTICE file present
>>>
>>> David
>>>
>>> On 2022/06/22 00:21:34 Alexander Saydakov wrote:
>>> > Hello Apache DataSketches PMC and Community,
>>> >
>>> >
>>> > This is a call for vote to release Apache DataSketches-cpp candidate
>>> > version: 3.5.0-rc1
>>> >
>>> >
>>> > Changes since datasketches-cpp 3.4.0 release
>>> > - Type converting constructors for KLL and REQ sketches
>>> > - Fixed KLL copy constructor (affects non-arithmetic types)
>>> > - Added internal check in CPC sketch compression to avoid problems
>>> with
>>> > static analysis
>>> >
>>> >
>>> > Source repository:
>>> >
>>> > -
>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIhGU_MnQ$
>>> >
>>> >
>>> > Git Tag for this release:
>>> >
>>> > -
>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/tree/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIuipl9aw$
>>> > <
>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrLL1OnRcQ$
>>> > on
>>> > branch 3.5.x
>>> >
>>> >
>>> > Git HashId for this release is:
>>> 2ce1f160f423c4636bb7f7e7fa015fbad7294e2e
>>> >
>>> >
>>> > The Release Candidate Dist (Zip Repository):
>>> >
>>> > -
>>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJvV8xilg$
>>> >
>>> >
>>> > The public signing key can be found in the KEYS file:
>>> >
>>> > -
>>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJ0YXr_3Q$
>>> >
>>> >
>>> >
>>> > The artifacts have been signed with key:
>>> >
>>> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY)
>>> <
>>> > alsay@apache.org>
>>> >
>>> >
>>> > Build & Test Guide:
>>> >
>>> > -
>>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIq4PdQBA$
>>> >
>>> >
>>> > The vote will be performed as follows:
>>> >
>>> > - This letter will be published on dev@ and remain open for at
>>> least 72
>>> > hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>>> votes or
>>> > a majority of (+1) PMC votes are acquired. Anyone in the community can
>>> vote.
>>> >
>>> >
>>> > Please vote accordingly:
>>> >
>>> >
>>> > [ ] +1 approve
>>> >
>>> > [ ] +0 no opinion
>>> >
>>> > [ ] -1 disapprove with the reason
>>> >
>>> >
>>> > Thanks,
>>> >
>>> > Alexander Saydakov
>>> >
>>> > alsay@apache.org
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
>>> For additional commands, e-mail: dev-help@datasketches.apache.org
>>>
>>>
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 3.5.0-rc1
Posted by Jon Malkin <jo...@gmail.com>.
+1
I checked
- signature and shasum
- followed build, test, and install instructions for linux
- tox
- checked signatures and shasum for all pypi files
I decided to try building an install package, too, which is a .deb for my
linux box. That failed with a message about a few additional fields needing
to be specified. They can be done on teh command line. but it's probably
worth debating adding them to the cmake file. I'm not sure the correct
approach here.
jon
On Mon, Jun 27, 2022 at 3:23 PM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Added PyPI artifacts since we distribute them through pypi.org
> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/pypi/
> Sorry for not having them prepared upfront.
>
> On Fri, Jun 24, 2022 at 8:01 AM David Cromberge <dc...@apache.org>
> wrote:
>
>> +1
>>
>> I checked:
>> - GPG signature
>> - SHA checksum
>> - cmake, build and test cpp
>> - local cpp install
>> - build and test python
>> - local python package install
>> - LICENSE, README and NOTICE file present
>>
>> David
>>
>> On 2022/06/22 00:21:34 Alexander Saydakov wrote:
>> > Hello Apache DataSketches PMC and Community,
>> >
>> >
>> > This is a call for vote to release Apache DataSketches-cpp candidate
>> > version: 3.5.0-rc1
>> >
>> >
>> > Changes since datasketches-cpp 3.4.0 release
>> > - Type converting constructors for KLL and REQ sketches
>> > - Fixed KLL copy constructor (affects non-arithmetic types)
>> > - Added internal check in CPC sketch compression to avoid problems with
>> > static analysis
>> >
>> >
>> > Source repository:
>> >
>> > -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIhGU_MnQ$
>> >
>> >
>> > Git Tag for this release:
>> >
>> > -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/tree/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIuipl9aw$
>> > <
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.0-rc1__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrLL1OnRcQ$
>> > on
>> > branch 3.5.x
>> >
>> >
>> > Git HashId for this release is: 2ce1f160f423c4636bb7f7e7fa015fbad7294e2e
>> >
>> >
>> > The Release Candidate Dist (Zip Repository):
>> >
>> > -
>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.0-rc1/__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJvV8xilg$
>> >
>> >
>> > The public signing key can be found in the KEYS file:
>> >
>> > -
>> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrJ0YXr_3Q$
>> >
>> >
>> >
>> > The artifacts have been signed with key:
>> >
>> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> > alsay@apache.org>
>> >
>> >
>> > Build & Test Guide:
>> >
>> > -
>> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!AgxWgljdJLp-Ai4TD-eL33DfimJzFNw48RmJYeOQpOQ8IdKlR4jILgEoIuRpFEde0ywg4uTLZojrcrIq4PdQBA$
>> >
>> >
>> > The vote will be performed as follows:
>> >
>> > - This letter will be published on dev@ and remain open for at
>> least 72
>> > hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>> votes or
>> > a majority of (+1) PMC votes are acquired. Anyone in the community can
>> vote.
>> >
>> >
>> > Please vote accordingly:
>> >
>> >
>> > [ ] +1 approve
>> >
>> > [ ] +0 no opinion
>> >
>> > [ ] -1 disapprove with the reason
>> >
>> >
>> > Thanks,
>> >
>> > Alexander Saydakov
>> >
>> > alsay@apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
>> For additional commands, e-mail: dev-help@datasketches.apache.org
>>
>>