You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2019/12/29 07:51:18 UTC

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #1003: limit minimum value of max_concurrency for auto_cl

TousakaRin opened a new pull request #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003
 
 
   保障max currency 不小于bthread concurrency

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1003: limit minimum value of max_concurrency for auto_cl

Posted by GitBox <gi...@apache.org>.
zyearn commented on a change in pull request #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003#discussion_r361894578
 
 

 ##########
 File path: src/brpc/policy/auto_concurrency_limiter.cpp
 ##########
 @@ -247,6 +253,7 @@ void AutoConcurrencyLimiter::UpdateMaxConcurrency(int64_t sampling_time_us) {
             _min_latency_us * _ema_max_qps / 1000000 *  (1 + _explore_ratio);
     }
 
+    next_max_concurrency = std::max(bthread::FLAGS_bthread_concurrency, next_max_concurrency);
     if (next_max_concurrency != _max_concurrency) {
         _max_concurrency = next_max_concurrency;
     }
 
 Review comment:
   这个文件的186行 _max_concurrency /= 2; 会出现_max_concurrency == 0么

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] zyearn commented on issue #1003: limit minimum value of max_concurrency for auto_cl

Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003#issuecomment-570110303
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] jamesge commented on issue #1003: limit minimum value of max_concurrency for auto_cl

Posted by GitBox <gi...@apache.org>.
jamesge commented on issue #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003#issuecomment-570112394
 
 
   @TousakaRin 请确认一下所有形如“_max_concurrency = "的地方都没有问题了。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] jamesge merged pull request #1003: limit minimum value of max_concurrency for auto_cl

Posted by GitBox <gi...@apache.org>.
jamesge merged pull request #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] TousakaRin commented on issue #1003: limit minimum value of max_concurrency for auto_cl

Posted by GitBox <gi...@apache.org>.
TousakaRin commented on issue #1003: limit minimum value of max_concurrency for auto_cl
URL: https://github.com/apache/incubator-brpc/pull/1003#issuecomment-576491535
 
 
   已经确认所有对_max_concurrency 的直接赋值都替换为函数AdjustMaxConcurrency

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org