[GitHub] [iceberg-docs] samredai commented on pull request #91: Replace themes with a single "iceberg-theme" that's shared by landing-page and docs site

[GitBox <gi...@apache.org>]

samredai commented on PR #91:
URL: https://github.com/apache/iceberg-docs/pull/91#issuecomment-1165066487

   Thanks @djamegoldston ! I removed the min-width from the markdown-body css and added grouping to the topnav elements. As for removing the Iceberg logo, that content actually comes from the `iceberg` repo and is copied over during a release so I'll open a PR over there.
   
   Here are some additional things I've fixed based on some offline feedback:
   - Replaced grid container on single pages with a fixed left nav and fixed TOC (single scrollbar on the right of the page)
   - Fixed the width of marketing content on the landing page
   - Vertical aligned the github and slack icons in the navbar
   - Moved `Project`, `Community`, `ASF`, and `Format` from the docs site leftnav and instead added dropdowns at the topnav (Added `Spec`, `View Spec`, and `Terms` under Project)
   - Fixed positioning of the search results so the first result's title isn't cut off
   - Removed external icon from `Javadoc` in docs site left nav


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org