You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2019/07/05 04:57:14 UTC

Review Request 71014: HIVE-21938: Add database and table filter options to PreUpgradeTool

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71014/
-----------------------------------------------------------

Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg.


Bugs: HIVE-21938
    https://issues.apache.org/jira/browse/HIVE-21938


Repository: hive-git


Description
-------

By default pre upgrade tool scans all databases and tables in the warehouse. 
Add database and table filter options to run the tool for a specific subset of databases and tables only.


Diffs
-----

  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 
  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION 
  upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd 


Diff: https://reviews.apache.org/r/71014/diff/1/


Testing
-------

New UTs for testing filtering


Thanks,

Krisztian Kasa


Re: Review Request 71014: HIVE-21938

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71014/
-----------------------------------------------------------

(Updated July 8, 2019, 8:20 a.m.)


Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg.


Bugs: HIVE-21938
    https://issues.apache.org/jira/browse/HIVE-21938


Repository: hive-git


Description (updated)
-------

By default pre upgrade tool scans all databases and tables in the warehouse. 
Add database table and table type filter options to run the tool for a specific subset of databases and tables only.


Diffs (updated)
-----

  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 
  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION 
  upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd 


Diff: https://reviews.apache.org/r/71014/diff/3/

Changes: https://reviews.apache.org/r/71014/diff/2-3/


Testing (updated)
-------

New UTs for testing filtering
Exsiting and new UTs passed.

Manually: 
1. deploy ambari and HDP 2.6.5 cluster.
2. create some hive tables and insert/update values
3. run PreUpgradeTool and check logs and output script


Thanks,

Krisztian Kasa


Re: Review Request 71014: HIVE-21938

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71014/
-----------------------------------------------------------

(Updated July 5, 2019, 7:11 p.m.)


Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg.


Bugs: HIVE-21938
    https://issues.apache.org/jira/browse/HIVE-21938


Repository: hive-git


Description
-------

By default pre upgrade tool scans all databases and tables in the warehouse. 
Add database and table filter options to run the tool for a specific subset of databases and tables only.


Diffs (updated)
-----

  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 
  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION 
  upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd 


Diff: https://reviews.apache.org/r/71014/diff/2/

Changes: https://reviews.apache.org/r/71014/diff/1-2/


Testing
-------

New UTs for testing filtering


Thanks,

Krisztian Kasa


Re: Review Request 71014: HIVE-21938

Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71014/
-----------------------------------------------------------

(Updated July 5, 2019, 5:49 a.m.)


Review request for hive, Eugene Koifman, Jesús Camacho Rodríguez, Zoltan Haindrich, and Vineet Garg.


Summary (updated)
-----------------

HIVE-21938


Bugs: HIVE-21938
    https://issues.apache.org/jira/browse/HIVE-21938


Repository: hive-git


Description
-------

By default pre upgrade tool scans all databases and tables in the warehouse. 
Add database and table filter options to run the tool for a specific subset of databases and tables only.


Diffs
-----

  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/PreUpgradeTool.java 0e3e3e2ed7 
  upgrade-acid/pre-upgrade/src/main/java/org/apache/hadoop/hive/upgrade/acid/RunOptions.java PRE-CREATION 
  upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd 


Diff: https://reviews.apache.org/r/71014/diff/1/


Testing
-------

New UTs for testing filtering


Thanks,

Krisztian Kasa