You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/08 02:48:39 UTC

[kudu-CR] docs: update scaling guide with new thread information

Hello Alex Rodoni, Jean-Daniel Cryans, Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9552

to review the following change.


Change subject: docs: update scaling guide with new thread information
......................................................................

docs: update scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
---
M docs/scaling_guide.adoc
1 file changed, 7 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9552/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, David Ribeiro Alves, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9552

to look at the new patch set (#5).

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................

docs: update release notes and scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
---
M docs/release_notes.adoc
M docs/scaling_guide.adoc
2 files changed, 15 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9552/5
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, David Ribeiro Alves, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9552

to look at the new patch set (#4).

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................

docs: update release notes and scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
---
M docs/release_notes.adoc
M docs/scaling_guide.adoc
2 files changed, 15 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9552/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 22:47:45 +0000
Gerrit-HasComments: No

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 5: Verified+1

Overriding Jenkins, there was an unrelated error in the Python3 build.


-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 23:38:10 +0000
Gerrit-HasComments: No

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................

docs: update release notes and scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Reviewed-on: http://gerrit.cloudera.org:8080/9552
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M docs/release_notes.adoc
M docs/scaling_guide.adoc
2 files changed, 15 insertions(+), 13 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/release_notes.adoc@109
PS2, Line 109: leader election storm
> putting my marketing hat on, maybe we shouldn't use the term "leader electi
I went with the latter.


http://gerrit.cloudera.org:8080/#/c/9552/2/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/scaling_guide.adoc@175
PS2, Line 175: Note that all replicas may be considered hot at startup, so tablet servers' thread usage will
             : generally peak when started and settle down thereafter.
> echoing the earlier question about this. WHy are all tablets hot at startup
I ran some experiments to figure this out, and yeah, it appears to be due to NO_OPs written at election time, and is especially bad for small (or worse, empty) tablets. Even with pre-elections adding some additional spacing, we end up with active WAL append and preallocation threads for almost every replica.



-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 21:44:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/release_notes.adoc@109
PS2, Line 109: leader election storm
putting my marketing hat on, maybe we shouldn't use the term "leader election storm" because we try our best to avoid such storms. Maybe better to just say "during Raft leader elections" or "such as the elections caused after a node failure" or somesuch


http://gerrit.cloudera.org:8080/#/c/9552/2/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/2/docs/scaling_guide.adoc@175
PS2, Line 175: Note that all replicas may be considered hot at startup, so tablet servers' thread usage will
             : generally peak when started and settle down thereafter.
echoing the earlier question about this. WHy are all tablets hot at startup? Is this due to the NO_OPs written to logs during the leader elections? I would guess that this would be worst if you have tons of very small tablets, so that they all bootstrap very quickly and thus are electing at more or less the same time?



-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 18:34:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@108
PS3, Line 108: the
remove?


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@109
PS3, Line 109: the
remove?


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@111
PS3, Line 111: As such, it should no longer be necessary to increase the value
             :   of `ulimit -u` (or of /proc/sys/kernel/threads-max) in order to run a Kudu
             :   tablet server.
maybe add somewhere "normally" or "in most cases"?


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc@187
PS3, Line 187: load
add: "with load or data/tablet size."



-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 22:03:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9552

to look at the new patch set (#3).

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................

docs: update release notes and scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
---
M docs/release_notes.adoc
M docs/scaling_guide.adoc
2 files changed, 15 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9552/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9552

to look at the new patch set (#2).

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................

docs: update release notes and scaling guide with new thread information

Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
---
M docs/release_notes.adoc
M docs/scaling_guide.adoc
2 files changed, 14 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9552/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] docs: update scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update scaling guide with new thread information
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9552/1/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/1/docs/scaling_guide.adoc@175
PS1, Line 175: Note that all replicas may be considered hot at startup, so tablet servers' thread usage will
             : generally peak when started and settle down thereafter.
Is this actually true though? Isn't the number of simultaneously bootstrapping replicas capped by the size of the bootstrap threadpool?



-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:51:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: update release notes and scaling guide with new thread information

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )

Change subject: docs: update release notes and scaling guide with new thread information
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@108
PS3, Line 108: the
> remove?
I actually think it reads better with this 'the' in place. I'm used to talking about steady state like that (i.e. "in the steady state, ...").


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@109
PS3, Line 109: the
> remove?
Upon rereading, I think this should actually be "in". So:  "the number of threads used during bursts of activity (such as in Raft leader elections triggered by a node failure)". That's because the threads are being used BY the leader elections, but since I already used BY in "by a node failure", IN is a reasonable substitute.


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@111
PS3, Line 111: As such, it should no longer be necessary to increase the value
             :   of `ulimit -u` (or of /proc/sys/kernel/threads-max) in order to run a Kudu
             :   tablet server.
> maybe add somewhere "normally" or "in most cases"?
Hmm, given the "hot replica" situation? I guess that's true.


http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc
File docs/scaling_guide.adoc:

http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc@187
PS3, Line 187: load
> add: "with load or data/tablet size."
Hmm, I thought "load" would be generic enough that it could serve as a proxy for any of those, but in context I suppose it could be viewed as the more specific "Kudu load such as active reads/writes". Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/9552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Mar 2018 22:18:01 +0000
Gerrit-HasComments: Yes