You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2026/08/28 06:25:16 UTC
[PR] [SPARK-59076][INFRA] Fix all Rust compiler warnings and deny warnings in CI [spark-connect-rust]
HyukjinKwon opened a new pull request, #76:
URL: https://github.com/apache/spark-connect-rust/pull/76
### What changes were proposed in this pull request?
The Rust build emitted `dead_code` warnings that never failed CI. This fixes all of them and turns warnings into **hard errors** so they cannot regress.
**Fixes**
- `observation.rs`: remove the unused `dataframe` field and the never-called `set_dataframe`/`set_metrics` methods (dead scaffolding — nothing referenced them; `DataFrame.observe()` is a separate DataFrame method).
- `profiler.rs`: `ProfileResult.metadata` is populated from profiler responses but not yet surfaced by `show()`/`dump()`; keep the collected data and mark it `#[allow(dead_code)]` with a note rather than discarding it.
- golden test suites (catalog/ml/ml_extra/readwriter/window): the `normalize_*`/`load_*`/`cint` helpers are copy-shared across the golden test binaries and each binary uses only a subset, so add a file-level `#![allow(dead_code)]` (the idiomatic treatment for shared cross-binary test helpers; it correctly overrides `-D warnings` for that scope).
**Enforcement**
- `rust.yml`: workflow-level `RUSTFLAGS=-D warnings`.
- `build_python_connect.yml`: job-level `RUSTFLAGS=-D warnings` on the *Rust checks* job (scoped so it does not gate the `pyspark-rs` extension build in the parity job).
- Cargo caps dependency lints to `allow`, so this only fails on warnings in our own workspace crates, never third-party deps.
### Why are the changes needed?
Warnings were accumulating unnoticed. A clean, warning-free build with enforcement keeps it that way.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI (this PR), now with `-D warnings` gating the Rust build/test and Rust checks jobs.
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59076][INFRA] Fix all Rust compiler warnings and deny warnings in CI [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #76: [SPARK-59076][INFRA] Fix all Rust compiler warnings and deny warnings in CI
URL: https://github.com/apache/spark-connect-rust/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org