[kudu-CR] Move configuration keys into its own class and make public

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 )

Change subject: Move configuration keys into its own class and make public
......................................................................


Patch Set 2:

Hey Clemens, sorry for the delay on this one.

I'm wary of exposing the actual key/value strings because it limits our ability to evolve things in the future. For example, we may want to start passing all of the info down into the class by serializing a protobuf into the configuration instead of all these separate string fields.

We already have the TableInputFormatConfigurator class with some methods for things like the table name, master addresses, etc. Is there an issue with using that from Hive?


-- 
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:07:54 +0000
Gerrit-HasComments: No