You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/09 03:25:06 UTC

[GitHub] [trafficserver] shinrich opened a new pull request #7588: Build the test library for tls_engine consistently

shinrich opened a new pull request #7588:
URL: https://github.com/apache/trafficserver/pull/7588


   @bneradt fixed all the other tests so that the supporting programs and libraries are built in the main build.  This PR fixes up the remaining test library, async_engine.so to be built the same way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #7588: Build the test library for tls_engine consistently

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7588:
URL: https://github.com/apache/trafficserver/pull/7588#issuecomment-793358181


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #7588: Build the test library for tls_engine consistently

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7588:
URL: https://github.com/apache/trafficserver/pull/7588#issuecomment-832836645


   Cherry-picked to v9.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] maskit commented on pull request #7588: Build the test library for tls_engine consistently

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7588:
URL: https://github.com/apache/trafficserver/pull/7588#issuecomment-796342100


   CI build fails on Ubuntu boxes.
   ```
   ../../tests/tools/plugins/async_engine.c: In function 'delay_method':
   ../../tests/tools/plugins/async_engine.c:230:3: error: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Werror=unused-result]
     230 |   write(signal_fd, &buf, sizeof(buf));
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../../tests/tools/plugins/async_engine.c: In function 'spawn_delay_thread':
   ../../tests/tools/plugins/async_engine.c:254:5: error: ignoring return value of 'pipe' declared with attribute 'warn_unused_result' [-Werror=unused-result]
     254 |     pipe(pipefds);
         |     ^~~~~~~~~~~~~
   cc1: all warnings being treated as errors
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich merged pull request #7588: Build the test library for tls_engine consistently

Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7588:
URL: https://github.com/apache/trafficserver/pull/7588


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org