You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Xiao Chen (JIRA)" <ji...@apache.org> on 2016/01/05 23:49:40 UTC

[jira] [Commented] (HADOOP-12546) Improve TestKMS

    [ https://issues.apache.org/jira/browse/HADOOP-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083990#comment-15083990 ] 

Xiao Chen commented on HADOOP-12546:
------------------------------------

I've seen some intermittent failures of TestKMS (testKMSProvider specifically), and this JIRA looks to be helpful on exposing more details of it. I reviewed through Patch 03, looks good to me, +1 (non-binding). Thanks [~templedf] and [~stevel@apache.org].

> Improve TestKMS
> ---------------
>
>                 Key: HADOOP-12546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12546
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: HADOOP-12546.001.patch, HADOOP-12546.002.patch, HADOOP-12546.003.patch
>
>
> The TestKMS class has some issues:
> * It swallows some exceptions' stack traces
> * It swallows some exceptions altogether
> * Some of the tests aren't as tight as they could be
> * Asserts lack messages
> * Code style is a bit hodgepodge
> This JIRA is to clean all that up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)