You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Lily Chen <li...@mesosphere.io> on 2015/08/06 22:34:29 UTC
Review Request 37197: Docker image store.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849
Repository: mesos
Description
-------
Stored images currently kept indefinitely.
Diffs
-----
src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81
src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46
src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
Diff: https://reviews.apache.org/r/37197/diff/
Testing
-------
make check
Thanks,
Lily Chen
Re: Review Request 37197: Docker image store.
Posted by Lily Chen <li...@mesosphere.io>.
> On Aug. 6, 2015, 9:34 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 123
> > <https://reviews.apache.org/r/37197/diff/1/?file=1033680#file1033680line123>
> >
> > End comment with period. And why not use ImageName as keys, or basically everywhere else in the provisioner?
ImageName had no hash function, also images functionality will be moved to reference store.
- Lily
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review94448
-----------------------------------------------------------
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 10:51 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stored images currently kept indefinitely.
>
>
> Diffs
> -----
>
> src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81
> src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
> src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
>
> Diff: https://reviews.apache.org/r/37197/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Lily Chen
>
>
Re: Review Request 37197: Docker image store.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review94448
-----------------------------------------------------------
src/slave/containerizer/provisioners/docker/store.hpp (line 123)
<https://reviews.apache.org/r/37197/#comment149056>
End comment with period. And why not use ImageName as keys, or basically everywhere else in the provisioner?
src/slave/containerizer/provisioners/docker/store.hpp (line 125)
<https://reviews.apache.org/r/37197/#comment149057>
What hash is this?
end comment with period too.
src/slave/containerizer/provisioners/docker/store.cpp (line 264)
<https://reviews.apache.org/r/37197/#comment149058>
Non-zero exit for tar subprocess for uri '" + uri + "', error: " + stringify(status.get())
- Timothy Chen
On Aug. 6, 2015, 8:34 p.m., Lily Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 8:34 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stored images currently kept indefinitely.
>
>
> Diffs
> -----
>
> src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81
> src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION
> src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION
> src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46
> src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e
>
> Diff: https://reviews.apache.org/r/37197/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Lily Chen
>
>