[GitHub] [pulsar] lhotari commented on pull request #9443: Try to fix flaky LeaderElection test.

[GitBox <gi...@apache.org>]

lhotari commented on pull request #9443:
URL: https://github.com/apache/pulsar/pull/9443#issuecomment-772344154


   @MarvinCai good work! I added a suggestion of using Awaitility for the waiting loop. 
   
   I have some concerns that the production code has some issues. I wrote about my observations in https://github.com/apache/pulsar/issues/9408#issuecomment-771552894 . There was a NPE stack trace with maximum 1024 stack frames. 
   
   [The NPE is easy to fix](https://github.com/apache/pulsar/commit/e8361f3656247a43c8928353d7e0a59784ddd25e)), but the depth of the stack is the concern. I did a quick check in the code and it looks like backoff with some delay is missing in some cases and the leader election can get into a very tight loop. I was hoping that @merlimat could check the comments in https://github.com/apache/pulsar/issues/9408#issuecomment-771561839 before #9408 is closed. I guess the other option is that I file a separate bug report about the observation.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org