You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/22 16:09:38 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

rkhachatryan opened a new pull request #12963:
URL: https://github.com/apache/flink/pull/12963


   ## What is the purpose of the change
   
   If `CheckpointCoordinator` is shutting down then `RejectedExecutionException`s are possible. They are logged separately at `DEBUG` level.
   However, they can be wrapped into `CompletionException`, in which case they are logged fully at `WARN` level, which fails e2e tests.
   
   This PR fixes it by searching for `RejectedExecutionException` in cause chain of the exception.
   
   ## Verifying this change
   
   This change is a trivial rework; e2e tests already cover this issue.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662568757


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741",
       "triggerID" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26cbc622c2ed413d4e14bbed17e39fb9dd449a80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-663034308


   Thanks for the fix, merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662568757


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26cbc622c2ed413d4e14bbed17e39fb9dd449a80 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662568757


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741",
       "triggerID" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4742",
       "triggerID" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26cbc622c2ed413d4e14bbed17e39fb9dd449a80 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741) 
   * eb8ceafd55cb781d6532752357263430fefaa6fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #12963:
URL: https://github.com/apache/flink/pull/12963


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662568757


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741",
       "triggerID" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4742",
       "triggerID" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eb8ceafd55cb781d6532752357263430fefaa6fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662568757


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741",
       "triggerID" : "26cbc622c2ed413d4e14bbed17e39fb9dd449a80",
       "triggerType" : "PUSH"
     }, {
       "hash" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "eb8ceafd55cb781d6532752357263430fefaa6fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26cbc622c2ed413d4e14bbed17e39fb9dd449a80 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4741) 
   * eb8ceafd55cb781d6532752357263430fefaa6fe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12963: [FLINK-18421][checkpointing] Fix logging of RejectedExecutionException logging

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12963:
URL: https://github.com/apache/flink/pull/12963#issuecomment-662544385


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 26cbc622c2ed413d4e14bbed17e39fb9dd449a80 (Wed Jul 22 16:11:16 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org