[GitHub] [griffin] RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

[GitBox <gi...@apache.org>]

RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r269582900
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/job/JobController.java
 ##########
 @@ -115,8 +120,19 @@ public JobHealth getHealthInfo() {
     }
 
     @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
-    @ResponseStatus(HttpStatus.NO_CONTENT)
-    public void triggerJob(@PathVariable("id") Long id) throws SchedulerException {
-        jobService.triggerJobById(id);
+    @ResponseStatus(HttpStatus.OK)
+    public JobInstanceBean triggerJob(@PathVariable("id") Long id, @RequestBody(required = false) String request) throws SchedulerException {
+        return jobService.triggerJobById(id, extractTimeOut(request));
+    }
+
+    private long extractTimeOut(String request) {
+        long timeout = 0;
 
 Review comment:
   @chemikadze on the other hand, such behavior corresponds to existing behavior, if I got it right. Otherwise it may happen that updated API introduces delays on requests where users perhaps don't expect them yet. Of course it would be amended by default value 0 for timeout in config... Well... I feel like this situation about timeout needs a bit more consideration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services