You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/01/27 18:54:10 UTC

[GitHub] [incubator-pinot] amrishlal commented on pull request #6403: [WORK IN PROGRESS] Fix upcasting/downcasting of numerical values used in SQL predicates.

amrishlal commented on pull request #6403:
URL: https://github.com/apache/incubator-pinot/pull/6403#issuecomment-768498727


   > Per the performance concern, can we always parse the String as double?
   
   The main reason why I used BigDecimal was that long to double to long conversion does not give back the original value since both are 64bit. I will look into this a bit more, but it is probably safer to lean in the direction of query correctness as compared to performance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org