You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by samk3211 <gi...@git.apache.org> on 2015/06/24 12:43:50 UTC
[GitHub] flink pull request: [FLINK-2264] [gelly] changed the tests to use ...
GitHub user samk3211 opened a pull request:
https://github.com/apache/flink/pull/863
[FLINK-2264] [gelly] changed the tests to use collect instead of temp…
… files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samk3211/flink myBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #863
----
commit c24358a90324a32d74ca4da29d6a4573eeda756a
Author: Samia <samia>
Date: 2015-06-24T10:41:34Z
[FLINK-2264] [gelly] changed the tests to use collect instead of temp files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2264] [gelly] changed the tests to use ...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/863#issuecomment-115194215
Thank you @samk3211! This looks good :)
I see that like here, @mjsax has also created a utils class for the new comparison methods in #866.
Since all migrated tests will be using these methods, I will just move them to `TestBaseUtils` before merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2264] [gelly] changed the tests to use ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---