[jira] [Commented] (HDFS-3710) libhdfs misuses O_RDONLY/WRONLY/RDWR

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421140#comment-13421140 ] 

Hadoop QA commented on HDFS-3710:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12537629/hdfs-3710.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
                  org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2890//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2890//console

This message is automatically generated.
                
> libhdfs misuses O_RDONLY/WRONLY/RDWR
> ------------------------------------
>
>                 Key: HDFS-3710
>                 URL: https://issues.apache.org/jira/browse/HDFS-3710
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>            Priority: Minor
>         Attachments: hdfs-3710.txt
>
>
> The {{O_RDONLY}} / {{O_WRONLY}} / {{O_RDWR}} macros in {{fcntl.h}} are not a bitmask; they are an enum stored in the low bits of the flag word.  The proper way to use them is
> {code}
> if ((flags & O_ACCMODE) == O_RDONLY)
> {code}
> rather than
> {code}
> if ((flags & O_RDONLY) == 0)
> {code}
> There are many examples of this misuse in {{hdfs.c}}.
> As a result of this incorrect testing, erroneous code may be accepted without error and correct code might not work correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira