You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Esko Luontola (JIRA)" <ji...@apache.org> on 2013/07/17 18:06:48 UTC

[jira] [Created] (DIRMINA-950) org.apache.mina.codec.IoBuffer#mark is untested and broken

Esko Luontola created DIRMINA-950:
-------------------------------------

             Summary: org.apache.mina.codec.IoBuffer#mark is untested and broken
                 Key: DIRMINA-950
                 URL: https://issues.apache.org/jira/browse/DIRMINA-950
             Project: MINA
          Issue Type: Bug
    Affects Versions: 3.0.0-M1
            Reporter: Esko Luontola


Currently the org.apache.mina.codec.IoBuffer#mark method sets the limit instead of the mark, which is different from java.nio.Buffer#mark.

Also IoBuffer has disturbingly low code coverage: 87% method and 77% line coverage according to IntelliJ IDEA. IoBuffer's such a central class, that I would expect it to have 100% [mutation coverage|http://pitest.org/]. There are even a bunch of methods that are never used: arrayOffset(), asReadOnlyBuffer(), mark(), reset().

I've found http://pitest.org/ to be very useful in finding untested code. I warmly recommend trying it out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira