You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/22 02:25:15 UTC

[GitHub] [incubator-mxnet] zixuanweeei commented on a change in pull request #16555: Upgrade MKL-DNN dependency to v1.0

zixuanweeei commented on a change in pull request #16555: Upgrade MKL-DNN dependency to v1.0
URL: https://github.com/apache/incubator-mxnet/pull/16555#discussion_r337311769
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -36,6 +36,14 @@
 import os
 
 def check_rnn_consistency(cell1, cell2, T, N, I, H, grad_req, rtol=1e-2, atol=1e-4):
+    if default_context().device_type == 'cpu':
+    # NOTE(zixuanweeei): Currently, we don't add `add` requests support on fused mkl-dnn rnn operator.
 
 Review comment:
   We tracked this issue by https://github.com/apache/incubator-mxnet/issues/16578. Some information will be added by another PR. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services